-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FencedFrameConfig IDL objects serializable #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Aug 22, 2023
domfarolino
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much lgtm % one nit!
1 task
domfarolino
approved these changes
Aug 26, 2023
github-actions bot
added a commit
that referenced
this pull request
Aug 26, 2023
SHA: cf06e42 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
FencedFrameConfig
objects serializable and defines serializing/deserializing steps for it.config
as an attribute of aFencedFrameConfig
, replacing it with a clone of the values it needs from the internalFenced Frame Config
struct.sharedStorageContext
directly to thenavigate
algorithm, which will read thesharedStorageContext
from the IDL object to theembedder shared storage context
in theFenced Frame Config
struct. This is done since we are no longer writing directly to theFenced Frame Config
struct in thesetSharedStorageContext()
algorithm.getNestedConfigs()
to account for the changes toFencedFrameConfig
.navigate
step that goes in parallel.[=fenced frame config=]
struct instead of the{{FencedFrameConfig}}
IDL object.Preview | Diff