-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme styles overridden by size
prop
#194
Comments
chakra-react-select/src/chakra-components/control.tsx Lines 63 to 64 in ce0ded5
|
Yeah this is currently the intended behavior, but I should probably specify better in the docs how that works. Because the The order of preference for applying styles from least preferred to most preferred is
Some styles other than ones based on vs. However, in this case I realize I could use So I'm curious, is there something specific you were trying to do? Were the docs just confusing about this point? Or alternatively, is there a different way you think these cases could be handled? |
Thanks for the thorough explanation. I appreciate that, and now understand better why you’ve done it this way. My expectation was to be able to control this via I would agree that you might pull For |
Yes, so the I wanted this to be reflected on the menu so the styles matched between the Does that make sense?
I can take another look through, and see if I can make some more inferences about styles based on the components they're supposed to be matching. For example, I could probably pull that border radius from the
I actually gave that a shot in #195 and I'll merge it soon, you can see the change here. |
Actually, about the border radius, I just realized I did that wrong... the border radius for |
Regarding |
Are you talking about setting But yeah, I see what you're saying. However, the use case seems to fall into a relatively niche category of styling choices and I don't think there's any way around what I'm doing for a lot of these styles. A lot of my manual styles need to exist in order for the variants/sizes to properly style each component that makes up I think your best bet would just be to override the styles that are not working properly with the |
So I just published There aren't a ton of style overrides left over, and at the end of the day you should be able to change any of the remaining styles I've overridden with I'm going to close this issue for now as there's nothing else I plan to do to change this, but feel free to continue to comment on it if there's anything more you want to discuss. |
Description
The below line will always override the border radius defined in
theme.components.Menu.$size.list
.chakra-react-select/src/chakra-components/menu.tsx
Line 90 in ce0ded5
chakra-react-select Version
4.2.2
Link to Reproduction
No response
TypeScript?
Steps to reproduce
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: