Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported CSS unit: rem #459

Closed
leonorader opened this issue Mar 15, 2020 · 2 comments
Closed

Unsupported CSS unit: rem #459

leonorader opened this issue Mar 15, 2020 · 2 comments

Comments

@leonorader
Copy link
Contributor

I love this lib, thanks for creating, it saved my life a few times 😄 ❤️
Anyway, we usually use rem in our designs and css files so I usually get this:

Unsupported CSS unit: rem at line 38. Skipping declaration.

Is it possible to add this as a feature?
I would be new to this library from a developer point of view, but do you think I could develop it and open a PR with this? Or I would really need the help of an experienced contributor?
I would love to help :)
@danfickle
Copy link
Owner

Hi @leonorader,

Thanks for the offer of help. I thought this would be a quick to fix so took it on. It turns out it took a few hours so I should have accepted your offer of a PR!

Anyway, it is fixed now. I would love some help with other issues, even if it is to answer some questions or investigate the cause of the issue.

Thanks again.
@leonorader
Copy link
Contributor Author

@danfickle Wow! :) Thank you very much! :))

I will try to help, sure! :)
@danfickle danfickle mentioned this issue May 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@danfickle @leonorader