Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in SoLoader#init. #99

Closed
wants to merge 1 commit into from
Closed

Fix race condition in SoLoader#init. #99

wants to merge 1 commit into from

Conversation

mhrheaume
Copy link
Contributor

If two threads call SoLoader#init at the same time, there is a chance
they both try to initialize sSoSources one after the other, which
eventually leads to an OverlappingFileLockException.

To fix this issue, add a double check after obtaining the write lock to
only initialize if sSoSources is still null.

Fixes #93.

If two threads call `SoLoader#init` at the same time, there is a chance
they both try to initialize `sSoSources` one after the other, which
eventually leads to an `OverlappingFileLockException`.

To fix this issue, add a double check after obtaining the write lock to
only initialize if `sSoSources` is still null.

Fixes #93.
@facebook-github-bot
Copy link

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@simpleton simpleton self-requested a review April 27, 2022 15:37
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 30, 2022
Summary:
**Feature**

Support pre-computing the dependency

**Fixes**

Wrongly loaded directApkLdPath(facebook/SoLoader#104)
SoLoader causes crashes on migration to an Android 12 device(facebook/SoLoader#100, facebook/SoLoader#88 )
Fix race condition in SoLoader#init(facebook/SoLoader#99)

**Full Changelog**: facebook/SoLoader@v0.10.3...v0.10.4

Reviewed By: charles011

Differential Revision: D37525875

fbshipit-source-id: a64e4021012128fe4a78d3ec9e955dae2ae35926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants