Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add analytics_label in FcmOptions + fix FcmOptions for WebpushFcmOptions #256

Merged
merged 4 commits into from
Jul 19, 2019
Merged

add analytics_label in FcmOptions + fix FcmOptions for WebpushFcmOptions #256

merged 4 commits into from
Jul 19, 2019

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Jun 27, 2019 •
edited
Loading

hiranya911
hiranya911 suggested changes Jul 19, 2019
View reviewed changes
messaging/messaging.go Outdated Show resolved Hide resolved
messaging/messaging.go Outdated Show resolved Hide resolved
messaging/messaging.go Outdated Show resolved Hide resolved
@chemidy chemidy removed their assignment Jul 19, 2019
@hiranya911 hiranya911 self-assigned this Jul 19, 2019
hiranya911
hiranya911 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chemidy. LGTM.
@hiranya911 hiranya911 changed the base branch from master to dev July 19, 2019 22:39
@hiranya911 hiranya911 merged commit cea9c39 into firebase:dev Jul 19, 2019
@chemidy chemidy mentioned this pull request Jul 19, 2019
Closed
@shubh261994
Copy link

Hi, can you merge these changes to master as well? We really need these changes.
@chemidy chemidy deleted the analytics_label branch August 9, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@chemidy @shubh261994 @hiranya911