Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fcm): Added support for sending an image URL with notifications #261

Merged
merged 12 commits into from
Sep 12, 2019
Merged

feat(fcm): Added support for sending an image URL with notifications #261

merged 12 commits into from
Sep 12, 2019

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Jul 19, 2019

  • add image option in notification

#259
@chemidy chemidy changed the title Image Jul 19, 2019
hiranya911
hiranya911 suggested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chemidy. Looks pretty good. Just a couple of comments.
messaging/messaging_utils.go Outdated Show resolved Hide resolved
messaging/messaging.go Outdated Show resolved Hide resolved
@hiranya911 hiranya911 changed the title add image option in notification Sep 6, 2019
@trilopin trilopin mentioned this pull request Sep 12, 2019
Closed
hiranya911
hiranya911 suggested changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Let's be consistent with naming: ImageURL vs Image.
messaging/messaging.go Outdated Show resolved Hide resolved
messaging/messaging_utils.go Outdated Show resolved Hide resolved
messaging/messaging_utils.go Outdated Show resolved Hide resolved
hiranya911
hiranya911 approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chemidy. LGTM 👍
@hiranya911 hiranya911 merged commit 11b2485 into firebase:dev Sep 12, 2019
@chemidy chemidy deleted the image branch December 1, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note
2 participants
@chemidy @hiranya911