Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Set FCMOptions for MulticastMessage #537

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

FZambia
Copy link
Contributor

@FZambia FZambia commented Feb 11, 2023

Hello!

Currently it's impossible to set FCMOptions for MulticastMessage. While for example in Python admin SDK this is possible. And in Java admin SDK. This pull request fixes this.

@google-cla
Copy link

google-cla bot commented Feb 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@FZambia
Copy link
Contributor Author

FZambia commented Feb 15, 2023

CLA signed

@lahirumaramba
Copy link
Member

lahirumaramba commented Mar 24, 2023

Hi @FZambia Thank you for your contribution. Please change the base branch to dev before we can start the review process.

https://github.com/firebase/firebase-admin-go/blob/master/CONTRIBUTING.md#want-to-submit-a-pull-request

Make sure to create all your pull requests against the dev branch. All development work takes place on this branch, while the master branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.

@FZambia FZambia changed the base branch from master to dev March 24, 2023 17:14
@lahirumaramba lahirumaramba changed the title Possibility to set FCMOptions for MulticastMessage Mar 28, 2023
@lahirumaramba lahirumaramba changed the title feat(fcm): Possibility to set FCMOptions for MulticastMessage Mar 28, 2023
@FZambia
Copy link
Contributor Author

FZambia commented May 13, 2023

Hello team, could you please tell when this will be released?

@FZambia FZambia force-pushed the multicast_message_fcm_options branch from 89ea601 to 8cb0fd4 Compare June 10, 2023 07:31
@FZambia
Copy link
Contributor Author

FZambia commented Jun 10, 2023

@lahirumaramba - any updates?

@FZambia
Copy link
Contributor Author

FZambia commented Dec 27, 2023

Guys, at least explain what prevents you from merging this?

@chong-shao
Copy link
Contributor

LGTM But I'd like to ask for waiting until @lahirumaramba 's review

@sebastianbuechler
Copy link

This would be nice to finally have in the package. @lahirumaramba can you please have a look at this minor change as it's only two lines of code and almost a year open?

@FZambia
Copy link
Contributor Author

FZambia commented Mar 3, 2024

@lahirumaramba kindly reminding 🙏

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lahirumaramba lahirumaramba merged commit ca81030 into firebase:dev Mar 11, 2024
6 checks passed
@lahirumaramba
Copy link
Member

Thanks folks! This change will be included in the next release

@FZambia
Copy link
Contributor Author

FZambia commented Mar 12, 2024

Nice, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants