-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fcm): Set FCMOptions for MulticastMessage #537
feat(fcm): Set FCMOptions for MulticastMessage #537
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
CLA signed |
Hi @FZambia Thank you for your contribution. Please change the base branch to
|
Hello team, could you please tell when this will be released? |
89ea601
to
8cb0fd4
Compare
@lahirumaramba - any updates? |
Guys, at least explain what prevents you from merging this? |
LGTM But I'd like to ask for waiting until @lahirumaramba 's review |
This would be nice to finally have in the package. @lahirumaramba can you please have a look at this minor change as it's only two lines of code and almost a year open? |
@lahirumaramba kindly reminding 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks folks! This change will be included in the next release |
Nice, many thanks! |
Hello!
Currently it's impossible to set
FCMOptions
forMulticastMessage
. While for example in Python admin SDK this is possible. And in Java admin SDK. This pull request fixes this.