Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Auth API to the new Identity Toolkit endpoint #256

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Migrating Auth API to the new Identity Toolkit endpoint #256

merged 5 commits into from
Feb 7, 2019

Conversation

hardikns
Copy link
Contributor

@hardikns hardikns commented Feb 4, 2019

Using the new Identity Toolkit REST endpoint for user management features. This is as per corresponding change in java (firebase/firebase-admin-java#220) and node SDKs.
@hardikns hardikns closed this Feb 4, 2019
@hardikns hardikns reopened this Feb 4, 2019
@hardikns
Copy link
Contributor Author

hardikns commented Feb 4, 2019 •
edited
Loading

@hiranya911 Can you please help on how to run Integration tests? I would like to do those before I submit the PR.

Specifically on what are the contents of the --cert (is this the standard service account json?) and --apikey file.
@hiranya911
Copy link
Contributor

@hardikns Check the CONTRIBUTING.md file for instructions.
@hardikns
Copy link
Contributor Author

hardikns commented Feb 6, 2019

@hiranya911 Can you please review the change? I plan to submit another in few days with changes around ooblink.

Meanwhile I did not find any documentation of the new Identity Toolkit. If you can point to the same that would help.
@hiranya911
Copy link
Contributor

@hardikns thanks for doing this. I will review this sometime this week.

@bojeil-google any pointers to the documentation of the new ID toolkit API?
@hiranya911 hiranya911 self-assigned this Feb 6, 2019
hiranya911
hiranya911 suggested changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid. Just a couple of minor changes needed.
CHANGELOG.md Outdated Show resolved Hide resolved
firebase_admin/auth.py Outdated Show resolved Hide resolved
tests/test_user_mgt.py Outdated Show resolved Hide resolved
hiranya911
hiranya911 approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hardikns for the contribution.
@hiranya911 hiranya911 merged commit 32d7dcd into firebase:master Feb 7, 2019
@hardikns hardikns deleted the hs_new_id_toolkit branch February 13, 2019 19:57
@hardikns
Copy link
Contributor Author

@bojeil-google can you please point me to the documentation on the new ID toolkit API?
@bojeil-google
Copy link
Contributor

If you mean the REST API, it is not yet documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@hardikns @hiranya911 @bojeil-google