-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): ability to delete provider in auth #579
Conversation
Thank for the PR @hardikns. There's an open PR #383 that implements this feature, but I'm not sure if the original authors are still available to finish up the work. @rsgowman @bojeil-google @nrsim are any of you available to finish and merge #383? If not we can accept this PR by @hardikns (it will likely need some minor changes to meet the approved API design). |
Ah, sorry; I forgot this was still outstanding. I don't think @nrsim will be available to finish #383, at least not for some time. @hardikns's PR has the advantage of not having to resolve 1y+ worth of merge conflicts. Though #383 also does linking (whereas this one just deletes). Since this PR likely only needs minor revision, we can probably get this one submitted quicker than #383. (And I assume @hardikns is waiting on this feature.) My vote is to proceed with this, and then rebase 383 ontop of this one. My only hesitation is that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hardikns. LGTM with a few nits. I can merge once those comments are addressed.
@hiranya911 I have addressed your comments and also updated my branch. Let me know if anything else is pending. |
This address #578,
Adds the feature in the python admin sdk (which has been present in the nodejs sdk) that will allow users to delete providers (like google.com, facebook.com). Basically add delete_providers as input to update_user method in auth.