[AppCheck] App Attest provider is supported by tvOS 15.0+ #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs
|
paulb777
approved these changes
Aug 12, 2022
andrewheard
approved these changes
Aug 12, 2022
FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckAvailability.h
Show resolved
Hide resolved
FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckAvailability.h
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs to cleanup App Check's availability guards.
#10094 focused on fixing AppCheck's watchOS CI and watchOS x DeviceCheck availability. This PR focuses on tvOS availability improvements as well as cleaning up some outdated logic.
I thought using the split view on this PR made it easier to understand the diff.
Context
This PR achieves two things:
FIRAppCheckAvailability.hwas created, I believe we were still supporting Xcode 12. Since Xcode 12.5 expanded availability for AppAttest, the availability logic was tailored to enable API based on Xcode version (since we had to support developers using minor versions before and after Xcode 12.5).Since we no longer support Xcode 12, we can simplify things by removing this.