Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public count #10246

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Public count #10246

merged 6 commits into from
Sep 23, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 22, 2022

No description provided.

@wu-hui wu-hui requested a review from dconeybe September 22, 2022 16:10
@dconeybe
Copy link
Contributor

Add a change log entry to Firestore/CHANGELOG.md

e.g.

- [feature] Added `Query.count()`, which fetches the number of documents in the
  result set without actually downloading the documents (#10246).
@google-oss-bot
Copy link

google-oss-bot commented Sep 22, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.95% (439b42d) to 87.93% (c4fd786) by -0.02%.

    FilenameBase (439b42d)Merge (c4fd786)Diff
    leveldb_key.cc98.14%98.63%+0.49%
    ordered_code.cc94.39%93.90%-0.49%
    serializer.cc91.26%90.95%-0.31%
    watch_stream.cc95.35%90.70%-4.65%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AeZrbzUQsV.html
@wu-hui
Copy link
Contributor Author

wu-hui commented Sep 22, 2022

Add a change log entry to Firestore/CHANGELOG.md

e.g.

- [feature] Added `Query.count()`, which fetches the number of documents in the
  result set without actually downloading the documents (#10246).

Done.
@wu-hui wu-hui requested a review from dconeybe September 23, 2022 00:32
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Sep 23, 2022
@wu-hui wu-hui merged commit 8aae6be into master Sep 23, 2022
@wu-hui wu-hui deleted the wuandy/PublicCount branch September 23, 2022 15:06
wu-hui added a commit that referenced this pull request Sep 23, 2022
@wu-hui
Revert "Public count (#10246)"
f00b0e2 
This reverts commit 8aae6be.
@wu-hui wu-hui mentioned this pull request Sep 23, 2022
Merged
wu-hui added a commit that referenced this pull request Sep 23, 2022
@wu-hui
Revert "Public count (#10246)" (#10252)
b695d99 
This reverts commit 8aae6be.
@dconeybe
Copy link
Contributor

Note that this PR was reverted because it was accidentally merged prematurely: #10252
wu-hui added a commit that referenced this pull request Sep 23, 2022
@wu-hui
Revert "Revert "Public count (#10246)" (#10252)"
28941f9 
This reverts commit b695d99.
ncooke3 pushed a commit that referenced this pull request Sep 24, 2022
@wu-hui @ncooke3
Public count (#10246)
c7d3975 
* Public Count

* Swift Test Commit

* Swift Format

* No extra whitespace

* Hopefully formatted.

* Change log and feedback.
ncooke3 pushed a commit that referenced this pull request Sep 24, 2022
@wu-hui @ncooke3
Revert "Public count (#10246)" (#10252)
7cd1b66 
This reverts commit 8aae6be.
ncooke3 added a commit that referenced this pull request Sep 24, 2022
@ncooke3 @paulb777
@eldhosembabu @charlotteliang @wu-hui @mortenbekditlevsen
[Firebase 10] Bump versions for 10.0.0 (#10244)
af1201c 
* [Firebase 10] Bump 9.X versions to 10.0.0

* Bump min. GTMSessionFetcher dep version to 2.1

* Bump min. GDT dep version to 9.2

* Bump min. GULs dep version to 7.8

* Fix unintentional nanopb replace

* Fix unintentional nanopb replace (2)

* Fix unintentional nanopb replace (3)

* Fix unintentional nanopb replace (4)

* Fix unintentional nanopb replace (4)

* Trigger all CI

* Bump FirebaseCombineSwift to 10

* Fix FirebaseStorage.podspec
I'm not sure what happened here. I had committed it during the rebase but guess not?

* Fix unintentional nanopb replace (5)

* Disable two tests to unblock staging

* Fix and re-enable FIROptions tests

* Update deployment targets in Firebase.podspec

* Add CHANGELOG entry for GTMSessionFetcher

* Fix AppCheck iOS availability

* Fix inadvertent API change (#10245)

* Docs update for Extensions and putFile (#10248)

* App google domain support (#10249)

Adding new 1p domain "app.google" support in FDL SDK.

* Remote Config Dynamic Property Wrapper (#10155)

* Separate GoogleUtilities Carthage build (#10250)

* Public count (#10246)

* Public Count

* Swift Test Commit

* Swift Format

* No extra whitespace

* Hopefully formatted.

* Change log and feedback.

* Revert "Public count (#10246)" (#10252)

This reverts commit 8aae6be.

* Make Firestore use FirebaseDataEncoder and FirebaseDataDecoder (re-implementation of #8858) (#9465)

* Bump tvOS minimum support version to 12.0

* [skip ci] Revert Gemfile

Co-authored-by: Paul Beusterien <paulbeusterien@google.com>
Co-authored-by: Eldhose M Babu <eldhosembabu@google.com>
Co-authored-by: Charlotte Liang <chliang@google.com>
Co-authored-by: wu-hui <53845758+wu-hui@users.noreply.github.com>
Co-authored-by: Morten Bek Ditlevsen <bek@termestrup.dk>
ehsannas added a commit that referenced this pull request Sep 28, 2022
@wu-hui @dconeybe @ehsannas
Public count (#10254)
4232ac1 
* Revert "Revert "Public count (#10246)" (#10252)"

This reverts commit b695d99.

* Firestore: Re-write API docs for COUNT API (#10258)

* Add isEqual and hash for aggregate classes (#10261)

Co-authored-by: Denver Coneybeare <dconeybe@google.com>
Co-authored-by: Ehsan <ehsannas@gmail.com>
ncooke3 added a commit that referenced this pull request Sep 28, 2022
@ncooke3
[Firestore] Update CHANGELOG for new Count API (#10246)
350a8fb
ncooke3 added a commit that referenced this pull request Oct 8, 2022
@ncooke3
[Firestore] Update CHANGELOG for new Count API (#10246) (#10278)
b7d0990
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore public-api-change
3 participants
@wu-hui @dconeybe @google-oss-bot