New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate androidClientID and trackingID #10520

Merged

paulb777 merged 1 commit into master from pb-firoptions-deprecations

Dec 15, 2022

Member

paulb777 commented Nov 23, 2022 •

edited

Loading

More context at https://github.com/firebase/firebase-ios-sdk/blob/master/docs/FirebaseOptionsPerProduct.md

Googlers: API review at go/api-deprecate-unused-firoptions


          Deprecate androidClientID and trackingID

bc89314

google-oss-bot added api: core public-api-change labels

paulb777 requested a review from charlotteliang

November 24, 2022 00:05

google-oss-bot commented Nov 24, 2022

Coverage Report ¹

Affected Products

FirebaseFirestore-iOS-FirebaseFirestore.framework
Overall coverage changed from 88.26% (7196035) to 88.25% (96c5b01) by -0.00%.
Filename Base (7196035) Merge (96c5b01) Diff
leveldb_key.cc 98.63% 98.43% -0.20%
task.cc 94.78% 93.91% -0.87%
write_stream.cc 91.55% 94.37% +2.82%

Test Logs

Base (7196035): https://github.com/firebase/firebase-ios-sdk/actions/runs/3527941281
Merge (96c5b01): https://github.com/firebase/firebase-ios-sdk/actions/runs/3536366100

https://storage.googleapis.com/firebase-sdk-metric-reports/HxGNXxhXAa.html

charlotteliang approved these changes

View reviewed changes

ncooke3 approved these changes

View reviewed changes

Member Author

paulb777 commented Nov 28, 2022

Will merge on API review approval

paulb777 merged commit 1fa2b4f into master

paulb777 deleted the pb-firoptions-deprecations branch

December 15, 2022 17:52

firebase locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.