Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge App check auth integration into master branch #11056

Merged
merged 6 commits into from
Apr 1, 2023
Merged

Merge App check auth integration into master branch #11056

merged 6 commits into from
Apr 1, 2023

Conversation

aiwenisevan
Copy link
Contributor

@aiwenisevan aiwenisevan commented Mar 31, 2023 •
edited by rosalyntan
Loading

Discussion

  • Integrate AppCheck and Auth for ios sdk, passing AppCheck token as a URL fragment according to this guide

Testing

Note: All changes (besides resolving merge conflicts) have been previously reviewed.
@aiwenisevan
Auth integration with AppCheck (#10798)
b167cc5 
* Auth App check integration without unit testing

* Add Unitest for AppCheck Auth Integration

* Style the format for Auth-Appcheck Integration

* Fix typo in import for FIRAppCheckInterop

* Style this file

* Fix wrong import

* Fix style for this file

* Fix style in this file

* Add Source path for FIRAppCheckInterop

* Add self to async block in Unit Test

* Fix: pass appcheckInterop to request configuration

* style the fixed files

* revert files that are only for local testing

* modify init method to avoid more changes

* remove extra comments

* upload for debug unit test

* Revert Sample changes and add appcheck into unit tests

* Fix issues in FIRAuthRequestConfiguration and typos in unit tests

* fix error loading and revert pod files

* Add spaces to keep style consistent
@aiwenisevan
pass appCheckToken as URL fragment (#10877)
02c439c 
* pass appCheckToken as URL fragment

* pass appcheck token as url fragments to phone provider

* for test purpose only: commented async function

* test if it is google cloud error

* formatting the file

* formatting the file

* fix comments issues

* remove printing function

* remove unused property

* Adding Unit test for passing appchecktoekn as a url fragment

* add import for FIRAppCheckTokenResultInterop

* Add separate file for FIRFakeAppCheck and Modify accordingly

* add copyright comments for bewly created files

* Add declaration for completion in FIRFakeAppCheck

* add correct param decalaration

* clean FIRFakeAppCheck.h

* add method in FIRAppcheck.h to avoid complaints

* correct copyright info

* fix typo in FIRFakeAppCheck.m

* Recover declarations

* solve comments issues
@paulb777
Copy link
Member

Please rebase or merge with the master branch
@aiwenisevan aiwenisevan marked this pull request as ready for review March 31, 2023 19:57
rosalyntan
rosalyntan approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@rosalyntan rosalyntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!
@aiwenisevan aiwenisevan merged commit 43cd9c2 into master Apr 1, 2023
@aiwenisevan aiwenisevan deleted the ApCheckAuthIntegration branch April 1, 2023 00:29
paulb777 added a commit that referenced this pull request Apr 2, 2023
@paulb777
[auth-swift] Merge AppCheck integration (#11056)
efec2de
@paulb777 paulb777 mentioned this pull request Apr 2, 2023
Merged
@firebase firebase locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: auth
4 participants
@aiwenisevan @paulb777 @rosalyntan @google-oss-bot