Remove references to deprecated CTCarrier for Sessions #11144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mrober
approved these changes
Apr 21, 2023
visumickey
approved these changes
Apr 21, 2023
| @@ -109,7 +109,7 @@ class SessionStartEvent: NSObject, GDTCOREventDataObject { | |||
| appInfo: ApplicationInfoProtocol) { | |||
| switch subscriber { | |||
| case .Performance: | |||
| proto.application_info.apple_app_info.mcc_mnc = makeProtoString(appInfo.mccMNC) | |||
| proto.application_info.apple_app_info.mcc_mnc = makeProtoString("") | |||
There was a problem hiding this comment.
Do we know what happens in the Backend when there is no radio information? Hopefully that does not drop the event due to validation failure?
There was a problem hiding this comment.
We never send a radio when just Crashlytics is installed, so this should not impact
samedson
force-pushed
the
ctcarrier-deprecated-sessions
branch
from
01d7c9b to
b872af7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/forums/thread/714876
Currently FirebaseSessions doesn't use this data, as it's still in development, so no customer impact.
TODO