Firebase Auth TOTP support #11261
Merged
Firebase Auth TOTP support #11261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
TOTP Enrollment Flow
Apple API Diff ReportCommit: 84f7dc4 FirebaseAuthClasses[ADDED] FIRTOTPMultiFactorGenerator[ADDED] FIRTOTPMultiFactorGeneratorObjective-C:
+ @interface FIRTOTPMultiFactorGenerator : NSObject
+ + ( void ) generateSecretWithMultiFactorSession : ( nonnull FIRMultiFactorSession * ) session completion :( nonnull void ( ^ )( FIRTOTPSecret * _Nullable , NSError * _Nullable )) completion ;
+ + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForEnrollmentWithSecret :( nonnull FIRTOTPSecret * ) secret oneTimePassword :( nonnull NSString * ) oneTimePassword ;
+ + ( nonnull FIRTOTPMultiFactorAssertion * ) assertionForSignInWithEnrollmentID :( nonnull NSString * ) enrollmentID oneTimePassword :( nonnull NSString * ) oneTimePassword ;[ADDED] FIRTOTPSecret[ADDED] FIRTOTPSecretSwift:
+ class TOTPSecret : NSObject
+ func sharedSecretKey () -> String
+ func generateQRCodeURL ( withAccountName accountName : String , issuer : String ) -> String
+ func openInOTPApp ( withQRCodeURL QRCodeURL : String )
Objective-C:
+ @interface FIRTOTPSecret : NSObject
+ - ( nonnull NSString * ) sharedSecretKey ;
+ - ( nonnull NSString * ) generateQRCodeURLWithAccountName :( nonnull NSString * ) accountName issuer :( nonnull NSString * ) issuer ;
+ - ( void ) openInOTPAppWithQRCodeURL :( nonnull NSString * ) QRCodeURL ;[ADDED] FIRTOTPMultiFactorAssertion[ADDED] FIRTOTPMultiFactorAssertionObjective-C:
+ @interface FIRTOTPMultiFactorAssertion : FIRMultiFactorAssertionConstants[ADDED] FIRTOTPMultiFactorID[ADDED] FIRTOTPMultiFactorIDObjective-C:
+ extern NSString * const _Nonnull FIRTOTPMultiFactorID |
Size Report 1Affected ProductsTest Logs |
* Added TOTP Assertion and Generator logics
Coverage Report 1Affected Products
Test Logs |
* Adding unenroll support for TOTP on sample app * lint fixes
* provide missing TOTP factor type of error in the error hints * refactor all sign in with MFA code in all related workflow for Sample App
* updated invalid verification code error msg
|
@kevinthecheung Hi Kevin, can you help with the documentation review? All code merged in this branch has already been approved by SWEs. |
* changes to umbrella and changelog * Update CHANGELOG.md * Update version as per PR feedback
paulb777
reviewed
Jun 20, 2023
FirebaseAuth/Sources/Backend/RPC/MultiFactor/Enroll/FIRFinalizeMFAEnrollmentResponse.m
Show resolved
Hide resolved
paulb777
reviewed
Jun 22, 2023
paulb777
approved these changes
Jun 22, 2023
kevinthecheung
approved these changes
Jun 23, 2023
FirebaseAuth/Sources/Public/FirebaseAuth/FIRTOTPMultiFactorGenerator.h
Outdated
Show resolved
Hide resolved
FirebaseAuth/Sources/Public/FirebaseAuth/FIRTOTPMultiFactorGenerator.h
Outdated
Show resolved
Hide resolved
FirebaseAuth/Sources/Public/FirebaseAuth/FIRTOTPMultiFactorAssertion.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Jun 29, 2023
This reverts commit dc754ba.
peterfriese
pushed a commit
that referenced
this pull request
Jul 14, 2023
Added Time-based One Time Password MFA support. Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com> Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TOTP MFA support for iOS SDK