Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase App Check One-time Use Tokens for Callable Functions SDK #11270

Merged
merged 31 commits into from
May 16, 2023
Merged

Firebase App Check One-time Use Tokens for Callable Functions SDK #11270

merged 31 commits into from
May 16, 2023

Conversation

aiwenisevan
Copy link
Contributor

@aiwenisevan aiwenisevan commented May 10, 2023 •
edited by ncooke3
Loading

Discussion

  • Implement one-time use token for Callable Functions SDK by following the proposal

Testing

  • Added unit tests

API Changes
@ncooke3
Copy link
Member

ncooke3 commented May 12, 2023

I've since updated the proposal with the latest revision. Introducing a new public HTTPSCallableOptions class is now part of the proposal.
paulb777
paulb777 reviewed May 12, 2023
View reviewed changes
FirebaseAppCheck/Interop/FIRAppCheckInterop.h Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Tests/ObjCIntegration/ObjCAPITests.m Show resolved Hide resolved
@ncooke3 ncooke3 force-pushed the callableFunctions branch from 2b591cd to bb8df26 Compare May 12, 2023 18:15
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023 •
edited
Loading

Apple API Diff Report

Commit: 00b8926
Last updated: Tue May 16 15:01 PDT 2023
View workflow logs & download artifacts

[BUILD ERROR] FirebaseFunctions
@ncooke3 ncooke3 mentioned this pull request May 12, 2023
Closed
@ncooke3 ncooke3 added this to the 10.10.0 - M132 milestone May 15, 2023
andrewheard
andrewheard approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My suggestions are all extremely nitpicky, feel free to ignore.
FirebaseFunctions/CHANGELOG.md Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/Functions.swift Outdated Show resolved Hide resolved
FirebaseFunctions/Sources/HTTPSCallableOptions.swift Outdated Show resolved Hide resolved
ncooke3 and others added 6 commits May 15, 2023 17:39
@ncooke3 @andrewheard
Update FirebaseFunctions/CHANGELOG.md
09183c1 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3 @andrewheard
Update FirebaseFunctions/Sources/Functions.swift
e304a1a 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3 @andrewheard
Update FirebaseFunctions/Sources/Functions.swift
7391807 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3 @andrewheard
Update FirebaseFunctions/Sources/Functions.swift
6b91923 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3 @andrewheard
Update FirebaseFunctions/Sources/Functions.swift
d5ef755 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3 @andrewheard
Update FirebaseFunctions/Sources/HTTPSCallableOptions.swift
16baf44 
Co-authored-by: Andrew Heard <andrewheard@google.com>
@sunmou99 sunmou99 mentioned this pull request May 16, 2023
Merged
andrewheard added a commit that referenced this pull request May 16, 2023
@andrewheard
[App Check] Always return fresh limitedUseToken
eb1fdf3 
Potential fix for #11270 (comment)
@andrewheard andrewheard mentioned this pull request May 16, 2023
Merged
@andrewheard
[App Check] Always return fresh limitedUseToken (#11298)
e30f75d 
Updated `limitedUseTokenWithCompletion:` to always return a fresh limited-used token in every invocation (removed the `ongoingLimitedUseTokenPromise` property).
@ncooke3 ncooke3 merged commit 0cbe4f2 into master May 16, 2023
@ncooke3 ncooke3 deleted the callableFunctions branch May 16, 2023 22:33
andrewheard added a commit that referenced this pull request May 19, 2023
@andrewheard
Merge latest FirebaseAppCheck changes from master
1f98441 
Merged FirebaseAppCheck changes from PRs #11224 and #11270.
@andrewheard andrewheard mentioned this pull request May 19, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: appcheck api: functions public-api-change
7 participants
@aiwenisevan @ncooke3 @google-oss-bot @paulb777 @ryanwilson @andrewheard @weixifan