Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow initializing FIRLocalCacheSettings with unlimited size. #11405

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Allow initializing FIRLocalCacheSettings with unlimited size. #11405

merged 8 commits into from
Jun 7, 2023

Conversation

tom-andersen
Copy link
Contributor

No description provided.

@tom-andersen tom-andersen linked an issue Jun 6, 2023 that may be closed by this pull request
Crash when setting FirestoreCacheSizeUnlimited value in PersistentCacheSettings #11389
Closed
@tom-andersen tom-andersen marked this pull request as ready for review June 6, 2023 16:21
@tom-andersen tom-andersen requested a review from wu-hui June 6, 2023 16:21
@tom-andersen tom-andersen requested a review from wu-hui June 7, 2023 14:42
@google-oss-bot
Copy link

google-oss-bot commented Jun 7, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.11% (e700a8f) to 88.15% (3c447a1) by +0.04%.

    FilenameBase (e700a8f)Merge (3c447a1)Diff
    exception.cc23.68%84.21%+60.53%
    FIRLocalCacheSettings.mm47.22%48.97%+1.74%
    leveldb_key.cc99.02%98.33%-0.69%
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LorvFfmtlA.html
wu-hui
wu-hui approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the condition to expand to test a bit more.
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Jun 7, 2023
@tom-andersen tom-andersen force-pushed the tomandersen/fixFirestoreCacheSizeUnlimited branch from 40f0838 to ac35a3e Compare June 7, 2023 17:59
@tom-andersen tom-andersen merged commit f2194c8 into master Jun 7, 2023
@tom-andersen tom-andersen deleted the tomandersen/fixFirestoreCacheSizeUnlimited branch June 7, 2023 23:53
@firebase firebase locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: core api: crashlytics api: firestore api: messaging api: performance
3 participants
@tom-andersen @google-oss-bot @wu-hui