Add CrashlyticsInputFiles.xcfilelist for Xcode 15 User Script Sandboxing #11428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs |
themiswang
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11400
Xcode 15 seems to make User Script Sandboxing default for new projects (and the default for upgrading your Xcode 14 project).
upload-symbols reads a bunch of files in the build folder. It also writes some temporary files there. Unfortunately this setting requires that you specify every input and output file in the Build Phase's Input / Output Files box.
Xcode also has Input Files Lists that is a file. The goal of this PR is to check-in this file for upload-symbols, and eventually have customers use this instead of the Input Files box (that developers must manage themselves).
That way the Crashlytics team can keep the upload-symbols Input Files up to date if we add / remove things.
How to Use This
Specify
${BUILD_DIR}/../../SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/CrashlyticsInputFiles.xcfilelistas your Input File Lists