-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to allow SDK create cache indexes automatically to improve query execution locally #11596
Conversation
338b6fd
to
e065099
Compare
Size Report 1Affected ProductsTest Logs |
9c0f65d
to
3f248b8
Compare
3f248b8
to
c58480a
Compare
Coverage Report 1Affected Products
Test Logs |
e1250c4
to
7c8e0ac
Compare
7c8e0ac
to
900f034
Compare
6deacda
to
36202ff
Compare
f65ba9c
to
758c809
Compare
32c4d88
to
6a8582b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half way through, l reviewed all the non-tests, there are some minor changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more small nits, I am approving it however.
This looks neat! Was checking documentation for possible integration in react-native-firebase and I may be wrong, but is the documentation for the API in sync? I see the API in use here: And I see a mention of the API here as the thing to use in future: https://firebase.google.com/docs/reference/ios/firebasefirestore/api/reference/Classes/FIRFirestore#-setindexconfigurationfromjson:completion: But I'm unable to find docs on the web for this object |
… query execution locally (#11596)
Preparing work for index auto creation feature.
#no-changelog