Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: NSSecureCoding support #12075

Closed
Juan2662 opened this issue Nov 8, 2023 · 3 comments · Fixed by #12110
Closed

[FR]: NSSecureCoding support #12075

Juan2662 opened this issue Nov 8, 2023 · 3 comments · Fixed by #12110

Comments

@Juan2662
Copy link

Juan2662 commented Nov 8, 2023

Description

Hi guys, I notice that some chunks in the code in iOS (like FirebaseMessaging) is using NSCoding protocol
I know you are working on that incrementally, but I would like to know when can we have full support for NSSecureCoding in all products?

API Proposal

No response

Firebase Product(s)

Messaging

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@paulb777
Copy link
Member

paulb777 commented Nov 8, 2023

A git grep shows the following NSCoding occurrences in Messaging and Database:

 $ git grep NSCoding
FirebaseDatabase/Sources/Persistence/FPendingPut.h:@interface FPendingPut : NSObject <NSCoding>
FirebaseDatabase/Sources/Persistence/FPendingPut.h:@interface FPendingPutPriority : NSObject <NSCoding>
FirebaseDatabase/Sources/Persistence/FPendingPut.h:@interface FPendingUpdate : NSObject <NSCoding>
FirebaseMessaging/Sources/Token/FIRMessagingAPNSInfo.h:@interface FIRMessagingAPNSInfo : NSObject <NSCoding, NSCopying>
FirebaseMessaging/Sources/Token/FIRMessagingAPNSInfo.m:#pragma mark - NSCoding
FirebaseMessaging/Sources/Token/FIRMessagingTokenInfo.h:@interface FIRMessagingTokenInfo : NSObject <NSCoding>
FirebaseMessaging/Sources/Token/FIRMessagingTokenInfo.m:#pragma mark - NSCoding
@paulb777
Copy link
Member

Only updating Messaging for now. FPendingPut in RTDB does not have tests and may only be used in an outdated code path.

@firebase firebase locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.