Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release Tooling] Rename gRPC-C++ framework to grpcpp #12437

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[Release Tooling] Rename gRPC-C++ framework to grpcpp #12437

merged 1 commit into from
Feb 28, 2024

Conversation

andrewheard
Copy link
Contributor

Updated the gRPC-C++ framework name to grpcpp to match the module name: https://github.com/grpc/grpc/blob/0d69f8dc7492507ed4280a55f97a06cc35a813d2/gRPC-C%2B%2B.podspec#L44-L47

#no-changelog
@andrewheard andrewheard changed the title Update gRPC-C++ framework name to match module name Feb 28, 2024
@andrewheard andrewheard marked this pull request as ready for review February 28, 2024 00:54
paulb777
paulb777 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

diff -r  ~/Downloads/Firebase-actions-dir-nightly/10_22_0/Firebase ~/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase | grep "Only in"
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-nightly/10_22_0/Firebase/FirebaseFirestore: gRPC-C++.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseFirestore: grpcpp.xcframework
@paulb777
Copy link
Member

And

diff -r /Users/paulbeusterien/Downloads/Firebase-actions-dir-nightly/10_22_0/Firebase/METADATA.md /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/METADATA.md
63d62
< - gRPC-C++.xcframework
64a64
> - grpcpp.xcframework
@paulb777 paulb777 merged commit 1e59292 into main Feb 28, 2024
59 checks passed
@paulb777 paulb777 deleted the ah/grpcpp-framework branch February 28, 2024 01:05
@andrewheard andrewheard mentioned this pull request Feb 28, 2024
Merged
@paulb777 paulb777 mentioned this pull request Mar 26, 2024
Closed
@firebase firebase locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-tooling
3 participants
@andrewheard @paulb777 @google-oss-bot