Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Tooling] Rename frameworks to match modules #12447

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

@andrewheard andrewheard changed the title Rename PromisesSwift framework to Promises Feb 28, 2024
@andrewheard andrewheard marked this pull request as ready for review February 28, 2024 22:44
@andrewheard andrewheard added this to the 10.22.0 - M144 milestone Feb 28, 2024
@andrewheard andrewheard merged commit 41050f0 into main Feb 29, 2024
59 checks passed
@andrewheard andrewheard deleted the ah/promises-swift branch February 29, 2024 03:59
@ncooke3
Copy link
Member

ncooke3 commented Feb 29, 2024

👍

XCFramework for BoringSSL-GRPC built successfully at file:///var/folders/h1/8hndypj13nsbj5pn4xsnv1tm0000gn/T/ZipRelease/2024-02-29T01-03-08/xcframeworks/openssl_grpc.xcframework.

@paulb777
Copy link
Member

Confirmed in file diff:

$  diff -r ~/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase ~/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase | grep "Only in"
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurement.xcframework/ios-arm64/GoogleAppMeasurement.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurement.xcframework/ios-arm64_x86_64-simulator/GoogleAppMeasurement.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurement.xcframework/tvos-arm64/GoogleAppMeasurement.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurement.xcframework/tvos-arm64_x86_64-simulator/GoogleAppMeasurement.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurementIdentitySupport.xcframework/ios-arm64/GoogleAppMeasurementIdentitySupport.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurementIdentitySupport.xcframework/ios-arm64_x86_64-simulator/GoogleAppMeasurementIdentitySupport.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurementIdentitySupport.xcframework/tvos-arm64/GoogleAppMeasurementIdentitySupport.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseAnalytics/GoogleAppMeasurementIdentitySupport.xcframework/tvos-arm64_x86_64-simulator/GoogleAppMeasurementIdentitySupport.framework: Info.plist
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseCrashlytics: Promises.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseCrashlytics: PromisesSwift.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseDatabase: leveldb-library.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseDatabase: leveldb.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseFirestore: BoringSSL-GRPC.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseFirestore: abseil.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseFirestore: absl.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseFirestore: gRPC-Core.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseFirestore: grpc.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebaseFirestore: leveldb-library.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseFirestore: leveldb.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebaseFirestore: openssl_grpc.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12447b/10_22_0/Firebase/FirebasePerformance: Promises.xcframework
Only in /Users/paulbeusterien/Downloads/Firebase-actions-dir-12437/10_22_0/Firebase/FirebasePerformance: PromisesSwift.xcframework
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants