Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11] [RTDB] Remove SocketRocket #13100

Merged
merged 2 commits into from
Jun 10, 2024
Merged

[v11] [RTDB] Remove SocketRocket #13100

merged 2 commits into from
Jun 10, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 8, 2024

Remove Socket Rocket source from RTDB source. This is a follow-on to #12894 now possible because of v11 updating the minimum platform os versions.

RTDB license files are updated. The zip NOTICES should be updated by nightly CI once this code is in main.

This PR also fixes a Package.swift warning with the location specifier of the Auth privacy manifest.

@paulb777 paulb777 requested review from ncooke3 and andrewheard June 10, 2024 14:34
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice red diff!

@paulb777 paulb777 merged commit 3af2f80 into release-11.0 Jun 10, 2024
52 of 62 checks passed
@paulb777 paulb777 deleted the pb-rm-socket-rocket branch June 10, 2024 17:25
pragatimodi pushed a commit that referenced this pull request Jun 17, 2024
@firebase firebase locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.