Potential data race in Storage method

[jesus-mg-ios]

Description

Reproducing the issue

Define a storage instance and call storage.reference(forURL: String) from multiple threads and sometimes the warn in Xcode happened.

 let task = Task {
            try await withCheckedThrowingContinuation { continuation in
                let storageReference = self.storage.reference(forURL: referencePath)
                storageReference.getData() { data, error in
                    if let error {
                        continuation.resume(throwing: error)
                        return
                    }
                    guard let data, !data.isEmpty else {
                        continuation.resume(throwing: Error.error)
                        return
                    }
                    continuation.resume(returning: data)
                }
            } as Data
        }

 return await task.value

Firebase SDK Version

10.25.0

Xcode Version

15.2

Installation Method

Swift Package Manager

Firebase Product(s)

Storage

Targeted Platforms

iOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[paulb777]

@jesus-mg-ios Thanks for the report. Would you check if #13381 fixes your test case?

[paulb777]

Nevermind. static methods in an actor aren't thread safe. A fix will take more investigation.

[jesus-mg-ios]

Maybe a dispatch queue async with a barrier flag could do the trick.

[paulb777]

Thanks. First, we'll see if we can address by migrating those internal APIs to Swift concurrency sometime in the next few weeks.