Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Remove unspecified enum cases from response types #13699

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[Vertex AI] Remove unspecified enum cases from response types #13699

merged 3 commits into from
Sep 23, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 23, 2024 •
edited
Loading

Removed the unspecified enum cases from FinishReason, BlockReason and HarmProbability. These should never be returned from the backend but, if ever, would be handled by the unknown case.
@andrewheard andrewheard added this to the 11.4.0 - M154.1 milestone Sep 23, 2024
@andrewheard andrewheard marked this pull request as ready for review September 23, 2024 19:10
@andrewheard andrewheard merged commit b4b8f24 into vertexai-release Sep 23, 2024
33 checks passed
@andrewheard andrewheard deleted the ah/vertex-rm-unspecified branch September 23, 2024 19:21
andrewheard added a commit that referenced this pull request Sep 24, 2024
@andrewheard
[Vertex AI] Remove unspecified enum cases from response types (#13699)
5fb5a5b
@firebase firebase locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vertexai
3 participants
@andrewheard @paulb777 @google-oss-bot