Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Use struct instead of enum for HarmCategory #13728

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[Vertex AI] Use struct instead of enum for HarmCategory #13728

merged 5 commits into from
Oct 8, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 26, 2024 •
edited
Loading

Replaced the HarmCategory enum with a struct to prevent breaking changes when new values are added (since switch statements must be exhaustively checked in Swift). Added support for HARM_CATEGORY_CIVIC_INTEGRITY.

#no-changelog
@andrewheard andrewheard force-pushed the ah/vertex-extensible-enum branch from 6049f5c to 5dc2415 Compare October 8, 2024 00:50
@andrewheard andrewheard changed the base branch from vertexai-release to main October 8, 2024 00:52
@andrewheard andrewheard closed this Oct 8, 2024
@andrewheard andrewheard reopened this Oct 8, 2024
@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 8, 2024
@andrewheard andrewheard marked this pull request as ready for review October 8, 2024 22:25
@andrewheard andrewheard requested a review from ncooke3 October 8, 2024 22:25
@andrewheard andrewheard merged commit 7bd6887 into main Oct 8, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-extensible-enum branch October 8, 2024 22:31
@andrewheard andrewheard mentioned this pull request Oct 8, 2024
Merged
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
@andrewheard @MojtabaHs
[Vertex AI] Use struct instead of enum for HarmCategory (fireba…
4b1dd4b 
…se#13728)
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vertexai public-api-change
4 participants
@andrewheard @paulb777 @ncooke3 @google-oss-bot