[Vertex AI] Simplify ModelContent initializers
#13832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # FirebaseVertexAI/Sources/GenerativeModel.swift
The initialzer with `some PartsRepresentable` offers a strict subset of the calls possible with the variadic parameter version. The array of PartsRepresentable doesn't gain anything over the variadic parameter version, and can actually lead to compiler confusion and require awkward casting.
…s-fixes # Conflicts: # FirebaseVertexAI/Sample/FunctionCallingSample/ViewModels/FunctionCallingViewModel.swift # FirebaseVertexAI/Sources/GenerateContentResponse.swift # FirebaseVertexAI/Sources/ModelContent.swift # FirebaseVertexAI/Sources/Types/Internal/InternalPart.swift # FirebaseVertexAI/Sources/Types/Public/Part.swift # FirebaseVertexAI/Tests/Integration/IntegrationTests.swift # FirebaseVertexAI/Tests/Unit/GenerativeModelTests.swift # FirebaseVertexAI/Tests/Unit/VertexAIAPITests.swift
paulb777
approved these changes
Oct 7, 2024
|
Thanks @ryanwilson for figuring this out! |
MojtabaHs
pushed a commit
to MojtabaHs/firebase-ios-sdk
that referenced
this pull request
Oct 17, 2024
Co-authored-by: Ryan Wilson <wilsonryan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ModelContentinitializer withsome PartsRepresentableoffers a strict subset of the calls possible with the variadic parameter version.The array of
PartsRepresentabledoesn't gain anything over the variadic parameter version, and can actually lead to compiler confusion and require awkward casting.