Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated keyWindow to new API #14048

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Change deprecated keyWindow to new API #14048

merged 2 commits into from
Nov 8, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Nov 7, 2024 •
edited
Loading

@themiswang themiswang requested a review from visumickey November 7, 2024 19:45
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

visumickey
visumickey approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks for making this.

I think this part of the code needs a bit of refactor later as to what are we measuring and how reliable it is. This is outside the scope of this PR.
@themiswang themiswang merged commit f2fa168 into main Nov 8, 2024
41 checks passed
@themiswang themiswang deleted the perfKeyWindowDep branch November 8, 2024 18:07
andrewheard added a commit that referenced this pull request Nov 11, 2024
@andrewheard
[Performance] Add changelog entry for #14048
3c9f54a
@andrewheard andrewheard mentioned this pull request Nov 11, 2024
Merged
@andrewheard andrewheard added this to the 11.5.0 - M156 milestone Nov 11, 2024
andrewheard added a commit that referenced this pull request Nov 11, 2024
@andrewheard
[Performance] Add changelog entry for #14048 (#14080)
4c855d7
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: performance
4 participants
@themiswang @google-oss-bot @visumickey @andrewheard