[auth] Fix logic inconsistency between 10.x and 11.x

[paulb777]

While investigating #14026 I found the following logic inconsistency after a keychain error in internalGetTokenAsync. It was potentially signing out when Firebase 10 did not.

I'm not sure how this could cause #14026, but we should keep the logic consistent.

I'm also open to suggestions about a cleaner solution that doesn't require the new flag.

Here's the Firebase 10 version:

- (void)internalGetTokenForcingRefresh:(BOOL)forceRefresh
                              callback:(nonnull FIRAuthTokenCallback)callback {
  [_tokenService fetchAccessTokenForcingRefresh:forceRefresh
                                       callback:^(NSString *_Nullable token,
                                                  NSError *_Nullable error, BOOL tokenUpdated) {
                                         if (error) {
                                           [self signOutIfTokenIsInvalidWithError:error];
                                           callback(nil, error);
                                           return;
                                         }
                                         if (tokenUpdated) {
                                           if (![self updateKeychain:&error]) {
                                             callback(nil, error);
                                             return;
                                           }
                                         }
                                         callback(token, nil);
                                       }];
}

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

[ncooke3]

Nice find!