-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reCAPTCHA enterprise support on phone auth and phone MFA #14114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoshouzi-gh
force-pushed
the
rce-main
branch
from
November 13, 2024 23:18
6f92c53
to
ba843d5
Compare
Xiaoshouzi-gh
force-pushed
the
rce-main
branch
from
November 19, 2024 18:25
2a9e392
to
73a7ede
Compare
paulb777
reviewed
Nov 25, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
paulb777
reviewed
Nov 25, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Nov 25, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Nov 26, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
paulb777
reviewed
Nov 26, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
paulb777
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix style and then LGTM
paulb777
approved these changes
Nov 26, 2024
ncooke3
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog
Added reCAPTCHA enterprise support for phone sign in and SMS as second factor sign in and enrollment flows.
changes log PR has been raised directly to main to avoid merging conflicts #14171