-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RemoteConfig] Crash if initializing after app start #3344
Comments
Hi @tecbot - looking into this right away. Some quick questions as I start investigating:
Thanks, and sorry for the troubles! |
I haven't been able to reproduce this using a non-Flutter app, looking at setting up Flutter in order to try it out. If you have a plain reproduction (without |
I have 2 crashes in same class in my apps :
|
@mouness2020 Thanks for the additional detail. @ryanwilson, @dmandar I suspect a thread safety issue with the static variable assigned the NSDateFormatter. One thread is creating another instance while another thread is sending the |
Thanks folks for the extra information - I have a pending fix internally at cl/258032937. We still haven't been able to reproduce this, so if anyone can provide reproduction steps so we can verify the fix works properly, it would be greatly appreciated. |
This crash should only happen if you are using FirePerf or if you have multiple active instances of RC (not common) in your app. Please let us know if it s not the case for you. |
Yes that's true i'm using FirePef .. also i have two firebase projects
|
We also experience this crash, we have a single instance of RC and we do use Firebase Performance. The crash happens half of the times on a clean install. Removing Firebase Performance fixes this issue. In the meantime we downgraded to 6.3.0 |
I also have this issue. It happens on fresh installs and old ones. My configuration on AppDelegate is
|
@igiazlas thanks for the report. Is reproducible for you on a local test device? If so, what iOS version and what device / simulator are you using? We have what we believe is a fix going into the next release that's being packaged and tested shortly, hopefully we can find a reliable repro to validate this issue goes away. |
I can reproduce it on an iPhone X running 12.3.1, on a 5s running 12.4 beta but not on a 6s running 11.4.1 (see edit). Also in all the 12.3.1 simulators I checked. It is consistent if I leave the last 3 lines in AppDelegate. If I remove them, and don't put them anywhere else, it does not crash, at least not for the first 20-30 seconds that I let it run. Edit: Before your last comment I downgraded to 6.3.0 and run the app on my devices with no problems. I upgraded again to make recheck the 11.4.1 6s and it didn't crash. The weird thing is that after I build for the other devices they also do not crash anymore. When I delete the app and rebuild it it starts crashing again. So on some old installs it does not crash but it does crash consistently on fresh installs (Delete, Build, Install) on all devices, including the 6s with 11.4.1. Edit 2: I have about 50 keys on my default configuration about 70 in total, including many that I do not use as they are used by the Android app Edit 3: It is not that consistent after all. In some cases, removing and reinstalling the app does not cause a crash. |
Hi there, As said before @b-onc, I suspect a conflict with Performance because I don't have the same problem after a migration of firebase on Carthage without performance. |
I also use Firebase Performance as @KevinLaRosa. This is the Firebase values I have on the Podfile.lock
|
@igiazlas can you verify which simulator versions you're using? As far as I'm aware there are no 12.3.1 simulators, only 12.2. |
I have half the time the crash on simulator 12.2.
|
@ryanwilson you are right, I meant to say the latest simulators which are 12.2 |
Based on all your input, we have made a fix for a race that occurs if Perf and RC SDK are both included, which should be out soon. @igiazlas can you also confirm you are also using FirePerf? If not, please confirm if you have the same stack trace. |
@dmandar yes, I also use FirePerf. I've posted my Podfile.lock above. |
Also experiencing the crash at times. Not present in 6.3.0 |
Firebase 6.5.0 just released with a fix. We were never able to reproduce the issue internally so would appreciate confirmation from those who saw the issue. |
@paulb777 I can confirm the fix. Thanks for your quick help! |
I was getting the similar crashes on app start during the UITests running on CI using Firebase 6.3. After upgrading to 6.5 today, and running couple of times I can no longer see this crash on startup. Thanks |
Same crash happening on |
@ppamorim can you please update to the latest version |
@ryanwilson I will, thanks. |
I am seeing this issue with Firebase (6.8.1)
|
@dmandar looks like a regression, can you investigate? |
@garypez This looks like #3842. Please follow the steps listed there to make sure you have a clean build. |
I'll close this one. Please follow up in #3842 if you're unable to resolve. |
@paulb777 @ryanwilson hi guys. I am trying to link performance sdk manually today and getting these same crashes on app launch. Will follow #3842 , but I am running iOS 12 still. Objective:install Firebase for an existing project without Cocoapods . Need manual install of frameworks. repro steps:manually installed Analytics package crash log :
what could be the problem? |
@valerianaGit please make sure you copy all of the frameworks from the Performance folder in the zip file. |
@ryanwilson thanks so much for the response. I did copy the entire folder (manual install, no pods) and (after clearing derived data, clean build and restarting my machine twice) I still get the above crash. It crashes here in Is there anything else we might be missing to initialize or anything? |
@valerianaGit can you open a new issue with your full stack trace and exception message (and ideally a sample project)? Your issue looks like a different crash than the parent. |
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
Stack trace:
Steps to reproduce:
After upgrading Firebase dependencies from 6.3.0 to 6.4.0 and RemoteConfig from 4.1.0 to 4.2.0 we are getting crashes directly on app start. If the crash happen the next app starts are working. After some time (~1 hour) the crash happen again. We are using Firebase in a Flutter project.
Relevant Code:
Entry point: https://github.com/flutter/plugins/blob/master/packages/firebase_remote_config/ios/Classes/FirebaseRemoteConfigPlugin.m#L39
The text was updated successfully, but these errors were encountered: