Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move two internal iid headers to private for RC open sourcing #3621

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Move two internal iid headers to private for RC open sourcing #3621

merged 2 commits into from
Aug 19, 2019

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Aug 18, 2019 •
edited
Loading

Migrate the two required InstanceID headers for RemoteConfig from internal to private.

After RC is added to the repo, consider consolidating ./Firebase/InstanceID/Private/FIRInstanceID+Private.h and
./Firebase/InstanceID/Private/FIRInstanceID_Private.h
maksymmalyhin
maksymmalyhin approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@paulb777 paulb777 merged commit 2741ec3 into master Aug 19, 2019
@paulb777 paulb777 deleted the pb-iid-private2 branch August 19, 2019 14:42
@charlotteliang charlotteliang added this to the M55 milestone Aug 27, 2019
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: instanceid cla: yes
4 participants
@paulb777 @maksymmalyhin @googlebot @charlotteliang