-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIRRemoteConfig Crashing on iOS 13 #3929
Comments
Thanks for the report - is there any way you could share a fully symbolicated crash log? It's tough to tell the actual crash here. This looks very similar to #3270 as well. Is it iOS 13.0 that is crashing, 13.1, or both? |
Haven't been able to trigger/replicate this crash that a lot of the users are experiencing in order to get over the crash dump logs. Crashlytics is saying 78% iOS 13.0, 21% iOS 13.1. I had a look at #3270, it does look very similar. Our users are also reporting uninstalling and reinstalling does not fix the problem. |
Hi, We're experiencing the same issue. It appears to be happening when the app launches, the main thread is dealing with code in: App: -[FIRRemoteConfig configValueForKey:namespace:] + 220
The app is crashing in a background thread. iOS: 13.0 (17A577) Podfile.lock info:
|
Apologies for the issues folks. We're working on getting this resolved as soon as possible. In the meantime, temporarily removing Firebase Performance from the project should resolve the issue if you need to ship an update. We'll keep this thread up to date with information on when a fix is found and ready. |
Is this happening all the time at startup? (We are not able to repro). This issue was known to be fixed in the Perf SDK. Some folks had lingering pods that were again showing the issue. Can you confirm this is not the case for you? E.g. #3842 |
We deploy builds from TravisCI which compile and ship builds from a clean VM slate which install the pods during that time so it doesn't look like there could be lingering pods that were removed but not completely "removed" |
@md-griddy @leandromperez Can you confirm this crash is happening on the version of your app that is using the latest version of the Perf SDK? Ideally the latest version should not face this crash. |
Yes, for sure our last two releases were on 3.1.4 and 3.1.2 Perf SDKs Users are experiencing immediate crash upon app startup |
@md-griddy After some debugging, we might have figured out the root cause of this issue and we will be rolling out a fix to the SDK in the upcoming release. ETA: October 8 2019. |
Awesome, thank you! |
Firebase 6.10.0 was released a few moments ago that should contain a fix for this issue. Please update and re-open the issue if it still persists. |
We're having the same crash even after updating to 6.10.0. |
@tomerciucran Is it the same backtrace as above? |
@paulb777 Yes. |
@tomerciucran Were you able to get this crash during development time or in production? If in production, is the volume of crash similar to earlier? |
@visumickey In development. We have Firebase version 5.20.2 currently in production. |
@tomerciucran That is nice you were able to catch in development. Few more questions:
|
@visumickey Sorry for the late response.
|
This is only tangentially related, but as a react-native-firebase maintainer, releasing a crash fix in the same semver as releasing breaking changes to MLKit makes it difficult to message to users what the compatibility matrix of versions is. This should be in 6.xx and the MLKit breaking stuff should have gone in a 7.0. This adds downstream support and documentation burden. |
@mikehardy MLKit is still in beta and I would recommend expectations be set for ongoing breaking changes. |
Developing for react-native makes one quite prepared for ongoing breaking changes :-), but the semver signaling helps sort them out and maintain coherent compatibility matrices is all. Failure to use that signal results in sleeper issues sometimes a couple dependencies downstream that waste troubleshooting time until someone bisects and discovers a hidden semver break like this expo/expo#5242 I don't intend to debate relative merit of semver or freedom to break in beta cycles - I empathize and I'm pragmatic. My point was just to note the consequence as things are built on these APIs already - beta or not |
@mikehardy I completely agree with the merits of semver and that's exactly why FirebaseMLKit is still at major version 0 to set the proper expectations. See bullet 4 at https://semver.org/ |
Hmm - this may be more of a style / transitive issue then. I think of the firebase ios SDK as a version-locked monorepo based on all the versions moving in step (eg 6.10) but under the covers that could be connecting with a differently-versioned FirebaseMLKit 0.x ? I'm not sure how to manage that. Also, apologies to participants here - didn't mean to rabbit hole on versioning in an active crash issue - I'll desist and open something separate if I have other questions. |
@tomerciucran Thanks for the details. We have been trying to reproduce the issue or find the scenario where this can happen. Will make sure to update this thread with findings and fixes. |
@tomerciucran Few of more information could be useful.
Sorry for requesting more information. These would be very helpful us to narrow down this issue. Appreciate your help in providing such useful information. |
Stack trace:
Podfile.lock:
Console logs:
|
Thanks @tomerciucran. We are investigating this to make sure we iron this out completely. |
I think we got the same issue! Fatal Exception: NSGenericException
Versions:
|
Thanks a lot for these inputs. We are on this and hoping to have a fix rolled out in the upcoming release. Will keep this thread posted. |
Will removing performance SDK temporarily fix this issue? Since the change log mentioned this is related to performance SDK |
@JohnnyTseng Sure. Removing performance SDK would mitigate the crashes for now. A permanent fix for this is being built and will rollout in the next few days to mitigate this issue. |
Thanks @visumickey , we can confirm that removing performance SDK does fixed this issue for our users temporarily. Still expecting a fix for this issue, Thanks for hard working! |
Hi @visumickey |
This issue is fixed and will be rolled out in the upcoming release of Firebase Performance. |
Firebase 6.13.0 was just released and should address this issue. Please update and re-open if you're still seeing the issue, thanks! |
We are getting roughly 255 crashes in production with 97% of users on iOS 13, the remaining 3% are on iOS 12. Utilizing all the latest Firebase pods versions.
Crash log & relevant backtrace:
The text was updated successfully, but these errors were encountered: