Enables Firebase Messaging push notification function on watch only and independent watch app #4016
Conversation
charlotteliang
requested review from
mikehaney24,
paulb777,
maksymmalyhin and
ryanwilson
|
It looks like there are code format issues. What is the unit testing strategy before @morganchen12's OCMock PR lands? |
|
This probably will break travis as I comment out systemConfiguration from podspec file, I've left the discussion in the description box. |
|
Here is an example of platform specific Apple framework dependencies - https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseStorage.podspec#L29 |
|
Nice Thanks Paul! |
|
To go forward, we should update relevant test_specs with all platforms except watchos like CocoaPods/CocoaPods#8283 (comment) |
|
We have to specify iOS 7 because pod lib lint failed at UIBackgroundFetchResult which is API_AVAILABLE(ios(7.0)). For some reason, this failed and not recognize UIBackgroundFetchResult if not specify iOS 7 above. |
|
Pod lib lint GoogleUtilities.podspec succeed locally but failed on travis : |
|
Might be because the other libraries run platform specific pod lib lint runs. That would probably be a better fix to update .travis.yml similarly for GoogleUtilities. |
| @@ -370,7 +370,9 @@ jobs: | |||
| env: | |||
| - PROJECT=GoogleUtilities METHOD=pod-lib-lint | |||
| script: | |||
There was a problem hiding this comment.
Looks good. Please make the same change for the GoogleUtilitiesCron job below.
There was a problem hiding this comment.
Done. There are two cmds under GoogleUtilitiesCron so I split each of them to 3 platforms.
| @@ -940,8 +943,7 @@ - (void)application:(GULApplication *)application | |||
| } | |||
| } | |||
|
|
|||
| #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 70000 | |||
| // This is needed to for the library to be warning free on iOS versions < 7. | |||
| #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 70000 && !TARGET_OS_WATCH | |||
There was a problem hiding this comment.
This is needed because of UIBackgroundFetchResult which is API_AVAILABLE(ios(7.0)). Somehow pod lib lint will fail if we ignore this check. I think something to do with the syntax API_AVAILABLE that checks below iOS 7 and it thinks UIBackgroundFetchResult is not recognized.
There was a problem hiding this comment.
Considering this is already there before my change, I can also add a todo for the owner to double check on this.
|
I also tested again on iOS and OSX to make sure the certificates are routed correctly. Will test tvOS once the lab is setup in new office again. |
This PR enables FCM push notification function on watch only app, and you can also send images/videos on notifications that deliver to watch only app or independent watch app. This is different than the watch app with an iOS companion app, where the watch app notification is delivered by apple system. For the independent watch app and watch only app, developers can request push notification independently inside the watch app, so it has its own apns token.
This is also part of the effort #269.
We can conditionally disable some of the FireLog and Reachability functionality if detected watchOS. Any feedback is welcome.