Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated sync -[FIRInstanceID appInstanceID:] method #4486

Closed
maksymmalyhin opened this issue Dec 11, 2019 · 4 comments · Fixed by #6677
Closed

Remove deprecated sync -[FIRInstanceID appInstanceID:] method #4486

maksymmalyhin opened this issue Dec 11, 2019 · 4 comments · Fixed by #6677
Assignees
@maksymmalyhin
Labels
api: instanceid
Milestone
Firebase 7 - M82

Comments

@maksymmalyhin
Copy link
Contributor

The method must be removed and [FIRInstanceID appInstanceID:] , all usages must be replaced the the async alternative.
@maksymmalyhin maksymmalyhin added this to the Firebase 7 milestone Dec 11, 2019
@maksymmalyhin maksymmalyhin self-assigned this Dec 11, 2019
@maksymmalyhin maksymmalyhin mentioned this issue Dec 11, 2019
Merged
@charlotteliang
Copy link
Contributor

If other SDKs like analytic stop using this, we should remove it. Thanks for filing this!
@maksymmalyhin
Copy link
Contributor Author

All Firebase SDKs (except FCM so far) have been updated to use FIS directly, but the method may still be used in some 1P tests.
@charlotteliang
Copy link
Contributor

charlotteliang commented May 11, 2020 •
edited
Loading

I think it's okay to remove it. I couldn't find any 1P depending on it anymore.
Since it's a private API, is it considered a breaking change? ( I see we mark it firebase 7)
@paulb777
Copy link
Member

We need to wait for Firebase 7 - because earlier Firebase 6 versions of other pods allow minor version updates of IID. If an old version of Firebase Analytics updates and this API is removed, the build will break.
@maksymmalyhin maksymmalyhin mentioned this issue Oct 6, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: instanceid
4 participants
@paulb777 @maksymmalyhin @morganchen12 @charlotteliang