Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating FCM Direct Channel API #4710

Merged
merged 12 commits into from
Feb 18, 2020
Merged

Deprecating FCM Direct Channel API #4710

merged 12 commits into from
Feb 18, 2020

Conversation

charlotteliang
Copy link
Contributor

No description provided.

@paulb777
Copy link
Member

paulb777 commented Feb 5, 2020

@chliangGoogle Is this ready for review?
@charlotteliang
Copy link
Contributor Author

We are still waiting for launchcal but the code is ready for review.
paulb777
paulb777 reviewed Feb 5, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving Approval to @ryanwilson for API changes
Firebase/Messaging/Public/FIRMessaging.h Outdated Show resolved Hide resolved
@ryanwilson
Copy link
Member

It looks like FIRMessagingMessageStatus was missed - please deprecate that as well. Also I believe this needs formatting, some of the lines with deprecation messages are quite long.
@charlotteliang
Copy link
Contributor Author

FIRMessagingMessageStatus is used by FIRMessagingMessageInfo that is used by appDidReceiveMessage: that is not deprecated.
I've updated the API review doc for this change. And run ./script/format on the header file.
@charlotteliang charlotteliang added this to the M65 milestone Feb 11, 2020
egilmorez
egilmorez approved these changes Feb 14, 2020
View reviewed changes
Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changelog text, thanks Chen!
@charlotteliang charlotteliang merged commit 27c4898 into master Feb 18, 2020
@charlotteliang charlotteliang deleted the fcm-mcs-deprecation branch February 18, 2020 18:36
@firebase firebase locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: messaging cla: yes
7 participants
@charlotteliang @paulb777 @ryanwilson @morganchen12 @egilmorez @googlebot @google-oss-bot