FIRApp: add apple platform to firebaseUserAgent #4939
Conversation
FirebaseCore/Sources/FIRApp.m
Outdated
| #endif // TARGET_OS_WATCH | ||
|
|
||
| #if TARGET_OS_MACCATALYST | ||
| applePlatform = @"maccatalyst"; |
There was a problem hiding this comment.
Please check that this define is not combined with any of the others. We might want it first with #elifs
There was a problem hiding this comment.
According to the current API docs it should not. I wonder if we can test it on Travis/GHA somehow?
There was a problem hiding this comment.
Ok, for Catalyst app run on macOS both TARGET_OS_IOS and TARGET_OS_MACCATALYST are set. I wonder what platform we would like to log in this case? I assume maccatalyst. WDYT?
There was a problem hiding this comment.
Updated with #elif accordingly.
| + (NSString *)applePlatform { | ||
| NSString *applePlatform = @"unknown"; | ||
|
|
||
| #if TARGET_OS_MACCATALYST |
There was a problem hiding this comment.
Add a comment summarizing the discussion so we remember this is order-sensitive
There was a problem hiding this comment.
Added the comment. Is it what you meant?
Collect stats on Firebase usage by Apple platform (b/146507104).