Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migration from legacy keychain #5237

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Mar 31, 2020

This was used to migrate checkin info for users who use a very old version of fcm or gcm to newer version. However, because most users have migrate off gcm and we no longer log substantial data in checkin, so it wouldn't hurt for small amount of users who get a new checkin and accordingly a new refresh token when updating.

This also reduce number of keychain read write operations during first app install.
Also update changelog for release.

…if user is updating from a very old version of FCM, however
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firebase/InstanceID/FIRInstanceIDCheckinStore.m needs formatting.

@charlotteliang charlotteliang merged commit 1054d6a into master Mar 31, 2020
@charlotteliang charlotteliang deleted the iid-legacy-keychain branch March 31, 2020 22:25
@firebase firebase locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.