Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crashlytics] [FIRCLSReportAdapter protoReport] method crashing when app launching #5565

Closed
ringtdblai opened this issue May 11, 2020 · 2 comments
Closed

[Crashlytics] [FIRCLSReportAdapter protoReport] method crashing when app launching #5565

ringtdblai opened this issue May 11, 2020 · 2 comments
Assignees
@morganchen12
Labels
api: crashlytics
Milestone
6.26.0 - M72

Comments

@ringtdblai
Copy link

Step 1: Describe your environment

Xcode version: 11.4.1
Firebase SDK version: 6.24.0
Firebase Component: Crashlytics
Component version: 4.1.0
Installation method: Manual

Step 2: Describe the problem
Steps to reproduce:
Got a crash previously and then it crashes every time when launching.
The console shows:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull dataUsingEncoding:]: unrecognized selector sent to instance 0x201ce80b0'

Last Exception Backtrace:
0   CoreFoundation                	0x1c37bc96c __exceptionPreprocess + 224
1   libobjc.A.dylib               	0x1c34d5028 objc_exception_throw + 59
2   CoreFoundation                	0x1c36badcc -[NSObject+ 200140 (NSObject) doesNotRecognizeSelector:] + 143
3   CoreFoundation                	0x1c37c1048 ___forwarding___ + 1327
4   CoreFoundation                	0x1c37c33a0 _CF_forwarding_prep_0 + 95
5   BNKitFramework                	0x106636ad8 FIRCLSEncodeString + 60
6   BNKitFramework                	0x106636a60 -[FIRCLSReportAdapter protoReport] + 455
7   BNKitFramework                	0x10663610c -[FIRCLSReportAdapter initWithPath:googleAppId:] + 155
8   BNKitFramework                	0x10663ba54 -[FIRCLSReportUploader uploadPackagedReportAtPath:dataCollectionToken:asUrgent:] + 443
9   BNKitFramework                	0x10663b580 __91-[FIRCLSReportUploader prepareAndSubmitReport:dataCollectionToken:asUrgent:withProcessing:]_block_invoke + 1395
10  BNKitFramework                	0x10661cc4c FIRCLSApplicationActivity + 91
11  BNKitFramework                	0x10663af54 -[FIRCLSReportUploader prepareAndSubmitReport:dataCollectionToken:asUrgent:withProcessing:] + 463
12  BNKitFramework                	0x1066392a0 -[FIRCLSReportManager processExistingActiveReportPath:dataCollectionToken:asUrgent:] + 191
13  BNKitFramework                	0x106639160 -[FIRCLSReportManager processExistingReportPaths:dataCollectionToken:asUrgent:] + 215
14  BNKitFramework                	0x10663896c -[FIRCLSReportManager beginReportUploadsWithToken:preexistingReportPaths:blockingSend:report:] + 139
15  BNKitFramework                	0x106638038 -[FIRCLSReportManager startWithProfilingMark:] + 1079
16  BNKitFramework                	0x106647320 -[FIRCrashlytics initWithApp:appInfo:installations:analytics:] + 911
17  BNKitFramework                	0x106647798 __38+[FIRCrashlytics componentsToRegister]_block_invoke + 347
18  BNKitFramework                	0x1065673b0 -[FIRComponentContainer instantiateInstanceForProtocol:withBlock:] + 67
19  BNKitFramework                	0x106567568 -[FIRComponentContainer instanceForProtocol:] + 223
20  BNKitFramework                	0x1065672a4 -[FIRComponentContainer instantiateEagerComponents] + 199
21  BNKitFramework                	0x106563798 +[FIRApp configureWithName:options:] + 759
22  BNKitFramework                	0x1065633dc +[FIRApp configureWithOptions:] + 99
23  BNKitFramework                	0x106563364 +[FIRApp configure] + 127
24  BNKitFramework                	0x10651e4a8 +[BNAnalytics setupLoggingWithDelegate:] + 550056 (BNAnalytics.m:363)
25  Nook                          	0x10456b1a8 -[BNAppDelegate application:didFinishLaunchingWithOptions:] + 29096 (BNAppDelegate.m:314)
26  BNCoreKit                     	0x106b5d23c -[BNCoreApplicationDelegateMethods application:didFinishLaunchingWithOptions:] + 1151548 (BNCoreApplicationDelegateMethods.m:55)
27  UIKitCore                     	0x1c78b3c18 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 343
28  UIKitCore                     	0x1c78b5a14 -[UIApplication _callInitializationDelegatesWithActions:forCanvas:payload:fromOriginatingProcess:] + 5111
29  UIKitCore                     	0x1c78bb340 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1251
30  UIKitCore                     	0x1c7053bec -[_UISceneLifecycleMultiplexer completeApplicationLaunchWithFBSScene:transitionContext:] + 151
31  UIKitCore                     	0x1c7505518 _UIScenePerformActionsWithLifecycleActionMask + 111
32  UIKitCore                     	0x1c7054724 __101-[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:]_block_invoke + 211
33  UIKitCore                     	0x1c7054154 -[_UISceneLifecycleMultiplexer _performBlock:withApplicationOfDeactivationReasons:fromReasons:] + 303
34  UIKitCore                     	0x1c7054540 -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 751
35  UIKitCore                     	0x1c7053dc4 -[_UISceneLifecycleMultiplexer uiScene:transitionedFromState:withTransitionContext:] + 339
36  UIKitCore                     	0x1c7058544 __186-[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:]_block_invoke_2 + 195
37  UIKitCore                     	0x1c751f39c ___UISceneSettingsDiffActionPerformChangesWithTransitionContext_block_invoke + 27
38  UIKitCore                     	0x1c74317bc +[BSAnimationSettings+ 5994428 (UIKit) tryAnimatingWithSettings:actions:completion:] + 867
39  UIKitCore                     	0x1c751f354 _UISceneSettingsDiffActionPerformChangesWithTransitionContext + 259
40  UIKitCore                     	0x1c705825c __186-[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:]_block_invoke + 151
41  UIKitCore                     	0x1c751f23c _UISceneSettingsDiffActionPerformActionsWithDelayForTransitionContext + 107
42  UIKitCore                     	0x1c70580b8 -[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:] + 391
43  UIKitCore                     	0x1c6ec0434 __64-[UIScene scene:didUpdateWithDiff:transitionContext:completion:]_block_invoke + 639
44  UIKitCore                     	0x1c6ebeef8 -[UIScene _emitSceneSettingsUpdateResponseForCompletion:afterSceneUpdateWork:] + 255
45  UIKitCore                     	0x1c6ec0164 -[UIScene scene:didUpdateWithDiff:transitionContext:completion:] + 235
46  UIKitCore                     	0x1c78b9730 -[UIApplication workspace:didCreateScene:withTransitionContext:completion:] + 563
47  UIKitCore                     	0x1c74536bc -[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:] + 375
48  FrontBoardServices            	0x1c89b1e10 -[FBSSceneImpl _callOutQueue_agent_didCreateWithTransitionContext:completion:] + 451
49  FrontBoardServices            	0x1c89d8aa0 __86-[FBSWorkspaceScenesClient sceneID:createWithParameters:transitionContext:completion:]_block_invoke.168 + 115
50  FrontBoardServices            	0x1c89bcef4 -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] + 239
51  FrontBoardServices            	0x1c89d8734 __86-[FBSWorkspaceScenesClient sceneID:createWithParameters:transitionContext:completion:]_block_invoke + 343
52  libdispatch.dylib             	0x1c3461fd8 _dispatch_client_callout + 19
53  libdispatch.dylib             	0x1c3464d1c _dispatch_block_invoke_direct + 263
54  FrontBoardServices            	0x1c89ff254 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 47
55  FrontBoardServices            	0x1c89fef00 -[FBSSerialQueue _queue_performNextIfPossible] + 431
56  FrontBoardServices            	0x1c89ff46c -[FBSSerialQueue _performNextFromRunLoopSource] + 31
57  CoreFoundation                	0x1c3738108 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 27
58  CoreFoundation                	0x1c373805c __CFRunLoopDoSource0 + 83
59  CoreFoundation                	0x1c37377c8 __CFRunLoopDoSources0 + 183
60  CoreFoundation                	0x1c3732694 __CFRunLoopRun + 1067
61  CoreFoundation                	0x1c3731f40 CFRunLoopRunSpecific + 479
62  GraphicsServices              	0x1cd9c2534 GSEventRunModal + 107
63  UIKitCore                     	0x1c78bd580 UIApplicationMain + 1939
64  Nook                          	0x104570470 main + 50288 (main.m:15)
65  libdyld.dylib                 	0x1c35b0e18 start + 3


Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001c35a6efc __pthread_kill + 8
1   libsystem_pthread.dylib       	0x00000001c34c68b8 pthread_kill + 228
2   libsystem_c.dylib             	0x00000001c3456af4 __abort + 116
3   libsystem_c.dylib             	0x00000001c3456a80 __abort + 0
4   libc++abi.dylib               	0x00000001c356e3c8 __cxa_bad_cast + 0
5   libc++abi.dylib               	0x00000001c356e5c0 demangling_unexpected_handler+ 5568 () + 0
6   libobjc.A.dylib               	0x00000001c34d5308 _objc_terminate+ 25352 () + 124
7   BNKitFramework                	0x0000000106651f0c FIRCLSTerminateHandler() + 1810188 (.cold.3) + 56
8   BNKitFramework                	0x0000000106625270 FIRCLSTerminateHandler+ 1626736 () + 276
9   libc++abi.dylib               	0x00000001c357b634 std::__terminate(void (*)+ 58932 ()) + 20
10  libc++abi.dylib               	0x00000001c357b5c0 std::terminate+ 58816 () + 44
11  libdispatch.dylib             	0x00000001c3461fec _dispatch_client_callout + 40
12  libdispatch.dylib             	0x00000001c3464d1c _dispatch_block_invoke_direct + 264
13  FrontBoardServices            	0x00000001c89ff254 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 48
14  FrontBoardServices            	0x00000001c89fef00 -[FBSSerialQueue _queue_performNextIfPossible] + 432
15  FrontBoardServices            	0x00000001c89ff46c -[FBSSerialQueue _performNextFromRunLoopSource] + 32
16  CoreFoundation                	0x00000001c3738108 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
17  CoreFoundation                	0x00000001c373805c __CFRunLoopDoSource0 + 84
18  CoreFoundation                	0x00000001c37377c8 __CFRunLoopDoSources0 + 184
19  CoreFoundation                	0x00000001c3732694 __CFRunLoopRun + 1068
20  CoreFoundation                	0x00000001c3731f40 CFRunLoopRunSpecific + 480
21  GraphicsServices              	0x00000001cd9c2534 GSEventRunModal + 108
22  UIKitCore                     	0x00000001c78bd580 UIApplicationMain + 1940
23  Nook                          	0x0000000104570470 main + 50288 (main.m:15)
24  libdyld.dylib                 	0x00000001c35b0e18 start + 4

Thread 1:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 2:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 4 name:  Dispatch queue: com.localytics.LLAnalyticsSilo_queue
Thread 4:
0   libsystem_kernel.dylib        	0x00000001c35a78f0 __ulock_wait + 8
1   libdispatch.dylib             	0x00000001c3462958 _dlock_wait + 56
2   libdispatch.dylib             	0x00000001c3462714 _dispatch_thread_event_wait_slow + 52
3   libdispatch.dylib             	0x00000001c346eaac __DISPATCH_WAIT_FOR_QUEUE__ + 336
4   libdispatch.dylib             	0x00000001c346e698 _dispatch_sync_f_slow + 144
5   Nook                          	0x00000001046401c4 +[BNNotificationsWrapper getNotificationTypes] + 260
6   Nook                          	0x00000001046402c8 +[BNNotificationsWrapper setCRMEnabledDimension] + 88
7   Nook                          	0x000000010456d2e4 -[BNAppDelegate localyticsSessionWillOpen:isUpgrade:isResume:] + 37604 (BNAppDelegate.m:687)
8   Localytics                    	0x00000001061bf458 0x106184000 + 242776
9   Localytics                    	0x00000001062158b0 0x106184000 + 596144
10  Localytics                    	0x00000001061f7b70 0x106184000 + 473968
11  Localytics                    	0x00000001061e1a24 0x106184000 + 383524
12  Localytics                    	0x00000001061bf280 0x106184000 + 242304
13  Localytics                    	0x00000001061f7b70 0x106184000 + 473968
14  libdispatch.dylib             	0x00000001c3460b7c _dispatch_call_block_and_release + 32
15  libdispatch.dylib             	0x00000001c3461fd8 _dispatch_client_callout + 20
16  libdispatch.dylib             	0x00000001c3468450 _dispatch_lane_serial_drain + 568
17  libdispatch.dylib             	0x00000001c3468e7c _dispatch_lane_invoke + 368
18  libdispatch.dylib             	0x00000001c3471f20 _dispatch_workloop_worker_thread + 580
19  libsystem_pthread.dylib       	0x00000001c34c76d0 _pthread_wqthread + 280
20  libsystem_pthread.dylib       	0x00000001c34cd9e8 start_wqthread + 8

Thread 5 name:  com.apple.uikit.eventfetch-thread
Thread 5:
0   libsystem_kernel.dylib        	0x00000001c3584c04 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001c3584020 mach_msg + 76
2   CoreFoundation                	0x00000001c3737964 __CFRunLoopServiceMachPort + 220
3   CoreFoundation                	0x00000001c37327fc __CFRunLoopRun + 1428
4   CoreFoundation                	0x00000001c3731f40 CFRunLoopRunSpecific + 480
5   Foundation                    	0x00000001c3a77340 -[NSRunLoop+ 33600 (NSRunLoop) runMode:beforeDate:] + 232
6   Foundation                    	0x00000001c3a77218 -[NSRunLoop+ 33304 (NSRunLoop) runUntilDate:] + 92
7   UIKitCore                     	0x00000001c7958e9c -[UIEventFetcher threadMain] + 156
8   Foundation                    	0x00000001c3a75fa4 -[NSThread main] + 40
9   Foundation                    	0x00000001c3bb1a74 __NSThread__start__ + 852
10  libsystem_pthread.dylib       	0x00000001c34c5840 _pthread_start + 168
11  libsystem_pthread.dylib       	0x00000001c34cd9f4 thread_start + 8

Thread 6:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 7:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 8:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 9:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 10:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 11:
0   libsystem_pthread.dylib       	0x00000001c34cd9e0 start_wqthread + 0

Thread 12 name:  com.google.firebase.crashlytics.MachExceptionServer
Thread 12:
0   libsystem_kernel.dylib        	0x00000001c3584c04 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001c3584020 mach_msg + 76
2   BNKitFramework                	0x000000010662c9a0 FIRCLSMachExceptionServer + 104
3   libsystem_pthread.dylib       	0x00000001c34c5840 _pthread_start + 168
4   libsystem_pthread.dylib       	0x00000001c34cd9f4 thread_start + 8

Thread 13 name:  com.apple.NSURLConnectionLoader
Thread 13:
0   libsystem_kernel.dylib        	0x00000001c3584c04 mach_msg_trap + 8
1   libsystem_kernel.dylib        	0x00000001c3584020 mach_msg + 76
2   CoreFoundation                	0x00000001c3737964 __CFRunLoopServiceMachPort + 220
3   CoreFoundation                	0x00000001c37327fc __CFRunLoopRun + 1428
4   CoreFoundation                	0x00000001c3731f40 CFRunLoopRunSpecific + 480
5   CFNetwork                     	0x00000001c6a37568 0x1c6a36000 + 5480
6   Foundation                    	0x00000001c3a75fa4 -[NSThread main] + 40
7   Foundation                    	0x00000001c3bb1a74 __NSThread__start__ + 852
8   libsystem_pthread.dylib       	0x00000001c34c5840 _pthread_start + 168
9   libsystem_pthread.dylib       	0x00000001c34cd9f4 thread_start + 8

After checking the source code in FIRCLSReportAdapter.m

- (google_crashlytics_Report)protoReport {
  google_crashlytics_Report report = google_crashlytics_Report_init_default;
  report.sdk_version = FIRCLSEncodeString(self.identity.build_version);
  report.gmp_app_id = FIRCLSEncodeString(self.googleAppID);
  report.platform = [self protoPlatformFromString:self.host.platform];
  report.installation_uuid = FIRCLSEncodeString(self.identity.install_id);
  report.build_version = FIRCLSEncodeString(self.application.build_version);
  report.display_version = FIRCLSEncodeString(self.application.display_version);
  report.apple_payload = [self protoFilesPayload];
  return report;
}

pb_bytes_array_t *FIRCLSEncodeString(NSString *string) {
  NSString *stringToEncode = string ? string : @"";
  NSData *stringBytes = [stringToEncode dataUsingEncoding:NSUTF8StringEncoding];
  return FIRCLSEncodeData(stringBytes);
}

It seems one of the strings being encoded in protoReport is NSNull.
@morganchen12
Copy link
Contributor

The fields being encoded there are all supposed to be nonnull fetches from plist files. If you're able to reproduce this crash on device, can you set an exception breakpoint and check which field is missing?
@morganchen12 morganchen12 self-assigned this May 11, 2020
@morganchen12 morganchen12 mentioned this issue May 12, 2020
Merged
@morganchen12
Copy link
Contributor

I'm submitting a PR to change the code so it will no longer crash, but depending on which field is missing you will likely see other issues, so definitely check that you identify what's causing the crash and fix it in your plists if necessary.
@firebase firebase locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: crashlytics
3 participants
@morganchen12 @ringtdblai @google-oss-bot