Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo-relative imports for Installations #5832

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Repo-relative imports for Installations #5832

merged 6 commits into from
Jun 17, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 16, 2020 •
edited
Loading

Update FirebaseInstallations and its dependencies for repo-relative headers

Dependency imports now use "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"

The source changes were made with this incarnation of scripts/change_headers.swift

The podspec and SPM infra changes were made manually.
@paulb777 paulb777 marked this pull request as draft June 16, 2020 21:01
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 marked this pull request as ready for review June 16, 2020 22:37
@paulb777 paulb777 requested a review from maksymmalyhin June 17, 2020 14:15
maksymmalyhin
maksymmalyhin approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Paul!
@paulb777 paulb777 merged commit c07c89e into master Jun 17, 2020
@paulb777 paulb777 deleted the pb-rr-installations branch June 17, 2020 14:27
granluo pushed a commit that referenced this pull request Jun 18, 2020
@paulb777 @granluo
Repo-relative imports for Installations (#5832)
3bb68ff
granluo pushed a commit that referenced this pull request Jul 7, 2020
@paulb777 @granluo
Repo-relative imports for Installations (#5832)
4d44c99
@firebase firebase locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: crashlytics api: inappmessaging Firebase In App Messaging api: installations api: instanceid api: messaging api: remoteconfig cla: yes
4 participants
@paulb777 @google-oss-bot @maksymmalyhin @googlebot