Repo-relative imports for Database #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymmalyhin
approved these changes
Jun 22, 2020
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Setup Bundler | ||
| run: scripts/setup_bundler.sh | ||
| - name: IntegrationTest | ||
| run: scripts/third_party/travis/retry.sh scripts/build.sh Database ${{ matrix.target }} integration | ||
| # Only iOS to mitigate flakes. |
There was a problem hiding this comment.
I wonder may the flakes occur due to concurrent tests execution (modifying the same database keys from tests fro different platforms simultaneously)? If so, we probably can fix it by modifying the tests, but it's probably out of scope of the PR.
There was a problem hiding this comment.
Yep, I wondered the same thing - but we've also disabled other tests in this suite because of flakiness from a single run.
In any case until we invest in improving the robustness of these tests, its not worth the cost of running the integration tests for non-iOS platforms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog - Will be part of a global M74 changelog