Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics: Add dispatch_once for opening sdk log file #5904

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Crashlytics: Add dispatch_once for opening sdk log file #5904

merged 1 commit into from
Jun 24, 2020

Conversation

cltnschlosser
Copy link
Contributor

Resolves #5903

I had a more complicated change earlier, but settled on this. The file is never closed, so this will work, and should be better than using a queue or semaphore.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@cltnschlosser
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@morganchen12 morganchen12 requested a review from samedson June 24, 2020 17:47
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Waiting for @samedson approval before merging, since this code may have non-obvious constraints.

Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cltnschlosser - thanks for the fix! This looks LGTM

@paulb777 paulb777 merged commit 043ff20 into firebase:master Jun 24, 2020
@cltnschlosser cltnschlosser deleted the cs_tsan_internalLogging branch June 25, 2020 00:06
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5 participants