Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Make public API for StackFrame creation from address #5975

Closed
segrey-profi opened this issue Jul 6, 2020 · 2 comments
Closed

FR: Make public API for StackFrame creation from address #5975

segrey-profi opened this issue Jul 6, 2020 · 2 comments
Labels
api: crashlytics type: feature request
Milestone
6.32.0 - M79

Comments

@segrey-profi
Copy link

segrey-profi commented Jul 6, 2020 •
edited
Loading

Feature proposal

  • Firebase Component: Crashlytics

Fabric SDK has public function CLSStackFrame(address:) which is needed for correct crash logging of Kotlin Multiplatform frameworks (see https://github.com/touchlab/CrashKiOS)

Firebase Crashlytics contains FIRCLSSymbolResolver class with frameForAddress: method which seems to do the same job, but it is private API so we cannot even check if it works for Kotlin frameworks.

Please make the same public API as CLSStackFrame(address:) in Fabric SDK.
@Thomas-Vos
Copy link

See also: #5182
@samedson samedson mentioned this issue Aug 25, 2020
Merged
@elenadoty
Copy link
Contributor

We've added this API to a branch that should be going out in the next release.
@paulb777 paulb777 added this to the 6.32.0 - M79 milestone Aug 26, 2020
@mikehardy mikehardy mentioned this issue Sep 8, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: crashlytics type: feature request
5 participants
@paulb777 @morganchen12 @Thomas-Vos @elenadoty @segrey-profi