Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics watchOS support #6262

Merged
merged 10 commits into from
Aug 13, 2020

Conversation

jostster
Copy link
Contributor

This PR resolves #4558 and adds crashlytics support for watchOS 6.0 +

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jostster
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

Please add to CI by updating https://github.com/firebase/firebase-ios-sdk/blob/master/.github/workflows/crashlytics.yml.

Since XCTest is not supported it should be:

target: [ios, tvos, macos, watchos --skip-tests].

See also GHA change in #6260

@jostster jostster requested a review from paulb777 August 12, 2020 21:35
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - #6263 should address the travis failure.

Deferring to @samedson for approval and merge

@jostster jostster requested a review from samedson August 13, 2020 16:46
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on this! Thanks for making it happen!

@jostster
Copy link
Contributor Author

@samedson looks like one check failed and was because of teamid during the build. I assume that is fine?

@paulb777
Copy link
Member

@jostster That build failure is addressed by #6263. I'll merge this one here. Thanks!

@paulb777 paulb777 merged commit 7c3235d into firebase:master Aug 13, 2020
@firebase firebase locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.