Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix minor code doc typos #6363

Merged
merged 1 commit into from
Aug 28, 2020
Merged

chore: fix minor code doc typos #6363

merged 1 commit into from
Aug 28, 2020

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented Aug 28, 2020 •
edited
Loading

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Found some extremely minor typos whilst snooping around implementing FlutterFire Crashlytics, so thought I'd send a quick PR 😅 thanks!

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.
@Salakar Salakar changed the title chore: fix code doc typos Aug 28, 2020
morganchen12
morganchen12 approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@morganchen12 morganchen12 added this to the 6.32.0 - M79 milestone Aug 28, 2020
@morganchen12 morganchen12 merged commit f86b1ad into firebase:master Aug 28, 2020
morganchen12 added a commit that referenced this pull request Aug 28, 2020
@morganchen12
Update changelog for #6363
e1c6cb7
morganchen12 added a commit that referenced this pull request Aug 28, 2020
@morganchen12
Update changelog for #6363 (#6364)
80e11b5
thebrianchen pushed a commit that referenced this pull request Sep 8, 2020
@Salakar
chore: fix code doc typos (#6363)
bdcd0b0
thebrianchen pushed a commit that referenced this pull request Sep 8, 2020
@morganchen12
Update changelog for #6363 (#6364)
9d23ba8
@firebase firebase locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes
3 participants
@Salakar @morganchen12 @googlebot