Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SCNReachability in Test Bundle #6413

Closed
ryantstone opened this issue Sep 8, 2020 · 5 comments · Fixed by #6426
Closed

Missing SCNReachability in Test Bundle #6413

ryantstone opened this issue Sep 8, 2020 · 5 comments · Fixed by #6426

Comments

@ryantstone
Copy link

Step 0: Are you in the right place?

  • For issues or feature requests related to the code in this repository
    file a Github issue.
    • If this is a feature request please use the Feature Request template.
  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general (non-iOS) Firebase discussion, use the firebase-talk
    google group.
  • For backend issues, console issues, and other non-SDK help that does not fall under one
    of the above categories, reach out to
    Firebase Support.
  • Once you've read this section and determined that your issue is appropriate for
    this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

  • Xcode version: Version 12.0 beta 5 (12A8189h)
  • Firebase SDK version: 6.32-SPM-beta
  • Firebase Component: FireStore (Auth, Core, Database, Firestore, Messaging, Storage, etc)
  • Component version: 6.32
  • Installation method: SPM

[REQUIRED] Step 2: Describe the problem

When running the test bundle I get:

Undefined symbols for architecture x86_64:
  "_SCNetworkReachabilityCreateWithAddress", referenced from:
      firebase::firestore::remote::(anonymous namespace)::CreateReachability() in SubFramework(FirebaseFirestore.o)
  "_SCNetworkReachabilitySetCallback", referenced from:
      firebase::firestore::remote::ConnectivityMonitorApple::ConnectivityMonitorApple(std::__1::shared_ptr<firebase::firestore::util::AsyncQueue> const&) in SubFramework(FirebaseFirestore.o)
  "_SCNetworkReachabilityGetFlags", referenced from:
      firebase::firestore::remote::ConnectivityMonitorApple::ConnectivityMonitorApple(std::__1::shared_ptr<firebase::firestore::util::AsyncQueue> const&) in SubFramework(FirebaseFirestore.o)
      firebase::firestore::remote::ConnectivityMonitorApple::OnEnteredForeground() in SubFramework(FirebaseFirestore.o)
  "_SCNetworkReachabilitySetDispatchQueue", referenced from:
      firebase::firestore::remote::ConnectivityMonitorApple::ConnectivityMonitorApple(std::__1::shared_ptr<firebase::firestore::util::AsyncQueue> const&) in SubFramework(FirebaseFirestore.o)
      firebase::firestore::remote::ConnectivityMonitorApple::~ConnectivityMonitorApple() in SubFramework(FirebaseFirestore.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The project runs fine, but the test bundle will fail if a specific combination of files is used.

Steps to reproduce:

I'm not sure of the steps, but I have an example project. Where it occurs.
https://github.com/ryantstone/Firebase-Bug-Example

If a single test is commented out (ConvertTests.test_timeToPickerValue_convertsHoursAndMinutes_toNativePickerData) the test suite will build and run, but if that test is in it will fail.

Steps to reproduce are in the Readme in the repo.

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@morganchen12
Copy link
Contributor

The test passes if commented out because the linker strips unused symbols. Can you try adding SystemConfiguration.framework to the Link Binary with Libraries part of your test target's Build Phases?

@ryantstone
Copy link
Author

It does build when adding it. Thank you.

@morganchen12
Copy link
Contributor

Closing this issue since it seems to be resolved, let me know if you need any more help.

@paulb777
Copy link
Member

paulb777 commented Sep 8, 2020

Going to reopen since this may have a similar resolution as #6408 with #6419.

@paulb777 paulb777 reopened this Sep 8, 2020
@paulb777 paulb777 self-assigned this Sep 9, 2020
@paulb777 paulb777 added this to the 6.33.0 - М80 milestone Sep 9, 2020
@firebase firebase locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.