Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated auth APIs #6607

Merged
merged 6 commits into from
Sep 30, 2020
Merged

Remove deprecated auth APIs #6607

merged 6 commits into from
Sep 30, 2020

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Sep 29, 2020

Remove deprecated APIs dataForKey,fetchProvidersForEmail:completion, signInAndRetrieveDataWithCredential:completion, reauthenticateAndRetrieveDataWithCredential:completion, linkAndRetrieveDataWithCredential:completion.

Fix #6544

@rosalyntan rosalyntan marked this pull request as ready for review September 30, 2020 21:23
@rosalyntan rosalyntan linked an issue Sep 30, 2020 that may be closed by this pull request
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also consider cleaning up usage of deprecated APIs like https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/Auth/FIRAuth.m#L1539 now that the minimum supported iOS version is 10 in this PR or a subsequent one.

@rosalyntan
Copy link
Member Author

Thanks! Also consider cleaning up usage of deprecated APIs like https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/Auth/FIRAuth.m#L1539 now that the minimum supported iOS version is 10 in this PR or a subsequent one.

Sounds good, will do in a followup PR!

@rosalyntan rosalyntan merged commit 14764b8 into master Sep 30, 2020
@rosalyntan rosalyntan deleted the rosalyntan.deprecation branch September 30, 2020 22:51
@firebase firebase locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.