Remove the FirebaseOptions() bare initializer.
#6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was unintentionally surfaced from the ObjC header and should be removed. Note: although the existing initializer doesn't work, this is still a breaking change.
maksymmalyhin
approved these changes
Oct 1, 2020
| @@ -173,6 +173,12 @@ - (id)copyWithZone:(NSZone *)zone { | |||
|
|
|||
| #pragma mark - Public instance methods | |||
|
|
|||
| - (instancetype)init { | |||
| // Unavailable. | |||
| [self doesNotRecognizeSelector:_cmd]; | |||
There was a problem hiding this comment.
I wonder if we really need this? The initializer marked as unavailable should lead to a compiler error, so I guess it should be enough. Or there is a specific case we would like to cover?
There was a problem hiding this comment.
Ah, forgot to link! I was watching the "Refine Objective-C frameworks for Swift" WWDC session and that was the suggestion: https://developer.apple.com/videos/play/wwdc2020/10680/?time=1159
They suggested this to make sure there's no accidental calls there. It also surfaced the copyWithZone: implementation calling the init function when it should have likely called one of the designated initializers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was unintentionally surfaced from the ObjC header and should be
removed.
Note: although the existing initializer doesn't work, this is still a
breaking change.
Fixes #5728
Following recommendations from https://developer.apple.com/videos/play/wwdc2020/10680