-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+[FIRApp registerInternalLibrary:withName:] take too much time #6902
Comments
I found a few problems with this issue:
|
Sadlly, according to my multi tests, the block time can be up to 100ms -_- |
The time cost is very important to our App, hope you can handle this ASAP. Thanks in advance! |
@shanksGuo Thank you for the detailed report pointing out to the exact place that causes issue for your application! We implemented some optimizations to avoid the slow part running from Unfortunately it's a bit too late to include the change to the next release, so it'll be include to the release after. In the meanwhile we will appreciate your feedback if you could test the #6919 changes from the branch. |
@maksymmalyhin Thank you. By the way, I have a question, I'm on release-7.0 now, if I want to fetch the code optimized, which branch can I use? |
@shanksGuo The changes have been merged to |
@maksymmalyhin Thank you, after checkout lastest code, it has been optimized. |
@shanksGuo Thank you for testing on you end! |
Feature proposal
As image shown below, [FIRApp registerInternalLibrary:withName:] in App launch Initializing phase take 78ms, it is too much for our App launch! So, could you optimize this.
Wish you accept this suggestion!
The text was updated successfully, but these errors were encountered: