Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple products named 'Reachability' in: GoogleUtilities, Reachability #7405

Closed
uniqby opened this issue Jan 29, 2021 · 8 comments
Closed

Comments

@uniqby
Copy link

uniqby commented Jan 29, 2021

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.4
  • Firebase SDK version: 7.5.0
  • Installation method: Swift Package Manager (select one)
  • Firebase Component: GoogleUtilites

[REQUIRED] Step 2: Describe the problem

Conflict with other swift package

Steps to reproduce:

I have dependency https://github.com/ashleymills/Reachability.swift, when I'm trying to update Firebase to version 7.5.0
I have an error:
multiple products named 'Reachability' in: GoogleUtilities, Reachability

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.
@Jeehut
Copy link

Jeehut commented Jan 29, 2021

Same issue here!

@Jeehut
Copy link

Jeehut commented Jan 29, 2021

I think this is related to SE-0226 which is only partially implemented and still has the bug in SR-8658. The easiest fix would be, if you would rename Rachability to something like FBReachability until the linked issue is fixed in a future Swift version. the Reachability library is quite common in many projects, also it's a helper target so I think it should be renamed here rather than on the Reachability library.

Jeehut added a commit to Jeehut/Reachability.swift that referenced this issue Jan 29, 2021
@Jeehut
Copy link

Jeehut commented Jan 29, 2021

@uniqby
I could work around this issue by forking ashleymills/Reachability.swift and renaming the library to Reachability.swift.
You just need to use the master branch of my fork https://github.com/Jeehut/Reachability.swift.git instead.

@scspijker
Copy link

Same issue here, but I think both libs need to rename as this is a big weakness in Swift.

@paulb777
Copy link
Member

Thanks for the report. I didn't realize that SPM had this namespace issue and introduced this problem in 7.5.0. I'll work on a fix. In the meantime, sticking to 7.4.0 would be another workaround.

@paulb777 paulb777 self-assigned this Jan 29, 2021
@paulb777
Copy link
Member

Here's a recommendation to prefix product names: https://forums.swift.org/t/logging-module-name-clash-in-vapor-3/25466/4

@paulb777
Copy link
Member

We've made a 7.5.1 distribution (only for Swift Package Manager) that addresses this issue with prefixes on the products in the GoogleUtilities package.

@firebase firebase locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.